Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.gymnasium: 0.29.1 -> 1.0.0 #313379

Merged
merged 3 commits into from
Oct 25, 2024
Merged

python312Packages.gymnasium: 0.29.1 -> 1.0.0 #313379

merged 3 commits into from
Oct 25, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented May 21, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage marked this pull request as draft May 21, 2024 12:08
@GaetanLepage GaetanLepage force-pushed the gymnasium branch 2 times, most recently from 09c3474 to fd2fb92 Compare May 21, 2024 12:18
@ofborg ofborg bot added 8.has: clean-up 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 1-10 labels May 21, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 22, 2024
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Jul 12, 2024 •
edited
Loading

Note for myself: Farama-Foundation/Shimmy#120

-> All good.

@GaetanLepage GaetanLepage marked this pull request as ready for review October 8, 2024 12:42
@GaetanLepage GaetanLepage mentioned this pull request Oct 8, 2024
Merged
7 tasks
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 8, 2024
@GaetanLepage GaetanLepage marked this pull request as draft October 8, 2024 15:15
@GaetanLepage GaetanLepage marked this pull request as ready for review October 22, 2024 12:28
@GaetanLepage
Copy link
Contributor Author

skrl failures are caused by wandb being broken.
This is unrelated and will be fixed by #350098

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 313379

x86_64-linux

❌ 2 packages failed to build:
  • python311Packages.skrl
  • python311Packages.skrl.dist
✅ 12 packages built:
  • python311Packages.ale-py
  • python311Packages.ale-py.dist
  • python311Packages.gymnasium
  • python311Packages.gymnasium.dist
  • python311Packages.minari
  • python311Packages.minari.dist
  • python311Packages.pettingzoo
  • python311Packages.pettingzoo.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.torchrl
  • python311Packages.torchrl.dist

aarch64-linux

❌ 2 packages failed to build:
  • python311Packages.skrl
  • python311Packages.skrl.dist
✅ 12 packages built:
  • python311Packages.ale-py
  • python311Packages.ale-py.dist
  • python311Packages.gymnasium
  • python311Packages.gymnasium.dist
  • python311Packages.minari
  • python311Packages.minari.dist
  • python311Packages.pettingzoo
  • python311Packages.pettingzoo.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.torchrl
  • python311Packages.torchrl.dist

x86_64-darwin

⏩ 22 packages marked as broken and skipped:
  • minari
  • minari.dist
  • python311Packages.ale-py
  • python311Packages.ale-py.dist
  • python311Packages.minari
  • python311Packages.minari.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.skrl
  • python311Packages.skrl.dist
  • python311Packages.torchrl
  • python311Packages.torchrl.dist
  • python312Packages.ale-py
  • python312Packages.ale-py.dist
  • python312Packages.minari
  • python312Packages.minari.dist
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.torchrl
  • python312Packages.torchrl.dist
✅ 6 packages built:
  • python311Packages.gymnasium
  • python311Packages.gymnasium.dist
  • python311Packages.pettingzoo
  • python311Packages.pettingzoo.dist
  • python312Packages.gymnasium
  • python312Packages.gymnasium.dist

aarch64-darwin

⏩ 16 packages marked as broken and skipped:
  • python311Packages.ale-py
  • python311Packages.ale-py.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.skrl
  • python311Packages.skrl.dist
  • python311Packages.torchrl
  • python311Packages.torchrl.dist
  • python312Packages.ale-py
  • python312Packages.ale-py.dist
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.torchrl
  • python312Packages.torchrl.dist
✅ 10 packages built:
  • minari (python312Packages.minari)
  • minari.dist (python312Packages.minari.dist)
  • python311Packages.gymnasium
  • python311Packages.gymnasium.dist
  • python311Packages.minari
  • python311Packages.minari.dist
  • python311Packages.pettingzoo
  • python311Packages.pettingzoo.dist
  • python312Packages.gymnasium
  • python312Packages.gymnasium.dist

@GaetanLepage GaetanLepage changed the title python311Packages.gymnasium: 0.29.1 -> 1.0.0 python312Packages.gymnasium: 0.29.1 -> 1.0.0 Oct 22, 2024
samuela
samuela reviewed Oct 22, 2024
View reviewed changes
pkgs/development/python-modules/gymnasium/default.nix Outdated
@@ -69,20 +76,28 @@ buildPythonPackage rec {
doCheck = !stdenv.hostPlatform.isDarwin;

disabledTestPaths = [
# mujoco is required for those tests but the mujoco python bindings are not packaged in nixpkgs.
# Unpackaged `mujoco-py` (Openai's mujoco) is required for those tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Unpackaged `mujoco-py` (Openai's mujoco) is required for those tests.
# Unpackaged `mujoco-py` (Openai's mujoco) is required for these tests.

since we're editing this line anyways

pkgs/development/python-modules/gymnasium/default.nix Show resolved Hide resolved
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 313379

x86_64-linux

✅ 14 packages built:
  • python311Packages.ale-py
  • python311Packages.ale-py.dist
  • python311Packages.gymnasium
  • python311Packages.gymnasium.dist
  • python311Packages.minari
  • python311Packages.minari.dist
  • python311Packages.pettingzoo
  • python311Packages.pettingzoo.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.skrl
  • python311Packages.skrl.dist
  • python311Packages.torchrl
  • python311Packages.torchrl.dist

aarch64-linux

✅ 14 packages built:
  • python311Packages.ale-py
  • python311Packages.ale-py.dist
  • python311Packages.gymnasium
  • python311Packages.gymnasium.dist
  • python311Packages.minari
  • python311Packages.minari.dist
  • python311Packages.pettingzoo
  • python311Packages.pettingzoo.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.skrl
  • python311Packages.skrl.dist
  • python311Packages.torchrl
  • python311Packages.torchrl.dist

x86_64-darwin

⏩ 20 packages marked as broken and skipped:
  • minari
  • minari.dist
  • python311Packages.ale-py
  • python311Packages.ale-py.dist
  • python311Packages.minari
  • python311Packages.minari.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.torchrl
  • python311Packages.torchrl.dist
  • python312Packages.ale-py
  • python312Packages.ale-py.dist
  • python312Packages.minari
  • python312Packages.minari.dist
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.torchrl
  • python312Packages.torchrl.dist
✅ 8 packages built:
  • python311Packages.gymnasium
  • python311Packages.gymnasium.dist
  • python311Packages.pettingzoo
  • python311Packages.pettingzoo.dist
  • python311Packages.skrl
  • python311Packages.skrl.dist
  • python312Packages.gymnasium
  • python312Packages.gymnasium.dist

aarch64-darwin

⏩ 16 packages marked as broken and skipped:
  • python311Packages.ale-py
  • python311Packages.ale-py.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.skrl
  • python311Packages.skrl.dist
  • python311Packages.torchrl
  • python311Packages.torchrl.dist
  • python312Packages.ale-py
  • python312Packages.ale-py.dist
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.torchrl
  • python312Packages.torchrl.dist
✅ 10 packages built:
  • minari (python312Packages.minari)
  • minari.dist (python312Packages.minari.dist)
  • python311Packages.gymnasium
  • python311Packages.gymnasium.dist
  • python311Packages.minari
  • python311Packages.minari.dist
  • python311Packages.pettingzoo
  • python311Packages.pettingzoo.dist
  • python312Packages.gymnasium
  • python312Packages.gymnasium.dist

@samuela samuela merged commit f2a2246 into NixOS:master Oct 25, 2024
28 checks passed
@GaetanLepage GaetanLepage deleted the gymnasium branch October 25, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuela samuela samuela approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GaetanLepage @samuela @wegank