-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jellyfin, jellyfin-web: 10.9.1 -> 10.9.3, 10.9.2 -> 10.9.3 #314775
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3989 |
Will this be backported to 24.05? |
Jellyfin 10.9.3 is out btw, maybe this PR should update jellyfin and jellyfin-web to 10.9.3 @nyanloutre @minijackson @purcell @jojosch |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to play with this PR locally, so I pushed a very similar change overall, but with 3 commits.
4aba7fc
to
f18db95
Compare
jellyfin
, jellyfin-web
: 10.9.1
-> 10.9.3
, 10.9.2
-> 10.9.3
jellyfin
, jellyfin-web
: 10.9.1
-> 10.9.3
, 10.9.2
-> 10.9.3
d55b056
to
67a13f3
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1687 |
The `default.nix` was also formatted with `nixfmt-rfc-style` to be `RFC 166`-compliant.
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-314775-to-release-23.11 origin/release-23.11
cd .worktree/backport-314775-to-release-23.11
git switch --create backport-314775-to-release-23.11
git cherry-pick -x a7441feb23f2ba370fb3ae130f51113c5c72b8f2 5cd7bbe6fef246db9c1e3cbbd4e26c45f8c13074 30dac56dab94c3dfbf50cd18c0003cf2d87839c1 |
1 similar comment
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-314775-to-release-23.11 origin/release-23.11
cd .worktree/backport-314775-to-release-23.11
git switch --create backport-314775-to-release-23.11
git cherry-pick -x a7441feb23f2ba370fb3ae130f51113c5c72b8f2 5cd7bbe6fef246db9c1e3cbbd4e26c45f8c13074 30dac56dab94c3dfbf50cd18c0003cf2d87839c1 |
Successfully created backport PR for |
Git push to origin failed for release-24.05 with exitcode 1 |
huh? Maybe the backport action didn't like me adding 2 tags at once. |
Description of changes
Updates
jellyfin
from10.9.1
to10.9.3
andjellyfin-web
from10.9.2
to10.9.3
. This also contains a change tojellyfin-web
that adds anassert
that only buildsjellyfin-web
if it is on the same version asjellyfin
. Note that usingnixfmt-rfc-style
changed thedefault.nix
ofjellyfin
, due to it not being formatted by it before.jellyfin-web
'sweb.nix
was unaffected by the formatting.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.