Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codd: init at 0.1.6 #338660

Merged

Conversation

mzabani
Copy link
Contributor

@mzabani mzabani commented Aug 31, 2024

Description of changes

Codd is developed by me and is essentially a tool that applies postgresql SQL migrations. Its homepage is https://github.com/mzabani/codd

Feel free to be direct and point out anything wrong here. I never had contributions merged into nixpkgs before.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Aug 31, 2024
@mzabani mzabani changed the title Add postgresql migration tool codd codd: init at 0.1.4 Aug 31, 2024
@mzabani mzabani marked this pull request as ready for review August 31, 2024 17:37
@mzabani mzabani force-pushed the add-codd-postgres-migration-tool branch from d4e226a to d841b63 Compare September 1, 2024 11:52
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay to me but I've no haskell experience, will probably let others review

@mzabani
Copy link
Contributor Author

mzabani commented Sep 10, 2024

@eclairevoyant what is the typical flow when adding new packages? Should I ping the Haskell maintainers? Or maybe I should ask in the discourse thread for a review?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4622

@FliegendeWurst FliegendeWurst added the 11.by: upstream-developer This issue or PR was created by the developer of packaged software label Nov 3, 2024
pkgs/development/tools/database/codd/default.nix Outdated Show resolved Hide resolved
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@mzabani mzabani force-pushed the add-codd-postgres-migration-tool branch from d841b63 to f7af0ba Compare November 10, 2024 12:10
@mzabani mzabani force-pushed the add-codd-postgres-migration-tool branch from 8c9ab25 to b81969f Compare November 10, 2024 13:46
pkgs/by-name/co/codd/generated.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/codd/generated.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 11, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@mzabani mzabani force-pushed the add-codd-postgres-migration-tool branch from 74a0b01 to 6a49788 Compare January 11, 2025 23:09
@FliegendeWurst FliegendeWurst added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 11, 2025
@wolfgangwalther wolfgangwalther dismissed FliegendeWurst’s stale review January 12, 2025 11:10

meta stuff didn't apply

@wolfgangwalther
Copy link
Contributor

Please squash your commits, so that you end up with two commits:

  • maintainers: add ...
  • codd: init at ..

@mzabani mzabani force-pushed the add-codd-postgres-migration-tool branch from 6a49788 to 7db718e Compare January 12, 2025 12:48
@mzabani
Copy link
Contributor Author

mzabani commented Jan 12, 2025

@wolfgangwalther done

@wolfgangwalther
Copy link
Contributor

I get build failures on darwin like this:

       >   test/WritingReadingRepresentationsSpec.hs:16:9:
       >   1) WritingReadingRepresentations, Writing and reading representations, persistRepsToDisk is inverse of readRepsFromDisk
       >        uncaught exception: IOException of type PermissionDenied
       >        /dev/shm: createDirectory: permission denied (Operation not permitted)
       >        (after 1 test)
       >          DbRepsGen {unDbRepsGen = DbRep Null (fromList []) (fromList [("bbix3\225u$\250vj",RoleRep "bbix3\225u$\250vj" (Array [Array []]))])}

@mzabani mzabani force-pushed the add-codd-postgres-migration-tool branch from 7db718e to acb7010 Compare January 12, 2025 19:52
@mzabani mzabani changed the title codd: init at 0.1.4 codd: init at 0.1.6 Jan 12, 2025
@mzabani
Copy link
Contributor Author

mzabani commented Jan 12, 2025

Oh, I'm terribly sorry. I only recently fixed those tests for MacOS and I forgot about that!
I just force-pushed a bump to codd 0.1.6, which should have those tests fixed for MacOS, as they now run in codd's CI with MacOS too.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 13, 2025
@wolfgangwalther
Copy link
Contributor

Yes, that fixes the darwin builds for me!

@wolfgangwalther wolfgangwalther merged commit d80668b into NixOS:master Jan 13, 2025
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 11.by: upstream-developer This issue or PR was created by the developer of packaged software 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants