-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codd: init at 0.1.6 #338660
codd: init at 0.1.6 #338660
Conversation
d4e226a
to
d841b63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okay to me but I've no haskell experience, will probably let others review
@eclairevoyant what is the typical flow when adding new packages? Should I ping the Haskell maintainers? Or maybe I should ask in the discourse thread for a review? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4622 |
d841b63
to
f7af0ba
Compare
8c9ab25
to
b81969f
Compare
74a0b01
to
6a49788
Compare
meta stuff didn't apply
Please squash your commits, so that you end up with two commits:
|
6a49788
to
7db718e
Compare
@wolfgangwalther done |
I get build failures on darwin like this:
|
7db718e
to
acb7010
Compare
Oh, I'm terribly sorry. I only recently fixed those tests for MacOS and I forgot about that! |
Yes, that fixes the darwin builds for me! |
Description of changes
Codd is developed by me and is essentially a tool that applies postgresql SQL migrations. Its homepage is https://github.com/mzabani/codd
Feel free to be direct and point out anything wrong here. I never had contributions merged into nixpkgs before.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.