Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ryujinx: remove package #345881

Closed
wants to merge 1 commit into from
Closed

ryujinx: remove package #345881

wants to merge 1 commit into from

Conversation

Naxdy
Copy link
Contributor

@Naxdy Naxdy commented Oct 2, 2024

This is not a PR I wanted to make, but sadly Ryujinx has been taken down upstream, and doesn't look like it's coming back. As per their official discord server:

image

The GitHub repo (and the entire org, in fact) is also no longer accessible: https://github.com/Ryujinx/Ryujinx/

Don't see a need to backport this to 24.05, because binary cache. Users customizing their builds (or one or more dependents) will find their build processes failing however, due to upstream being gone.

Since this doesn't appear to have been the result of a DMCA takedown, but rather a voluntary decision, for those who wish to continue building Ryujinx from source, I offer my self-hosted mirror repo here: https://git.naxdy.org/Mirror/Ryujinx - don't rely on this being around forever, though.

Closes #345758
Closes #325857
Closes #345410
Closes #187020

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Naxdy Naxdy requested review from AndersonTorres and emilazy and removed request for AndersonTorres October 2, 2024 07:56
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Oct 2, 2024
@Naxdy Naxdy requested review from AndersonTorres, Ma27 and emilazy and removed request for emilazy October 2, 2024 07:56
@Naxdy Naxdy force-pushed the work/remove-ryujinx branch from 8474a04 to d68e985 Compare October 2, 2024 07:58
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Life is not fair...

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 2, 2024
@Naxdy Naxdy requested review from artemist and 06kellyjac October 2, 2024 09:57
@niklaskorz
Copy link
Contributor

Before some trigger-happy person presses the merge button, please have a look at the ongoing discussion in #345758 where the current maintainer of the package explicitly speaks against removal.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 2, 2024
@Frontear
Copy link
Member

Frontear commented Oct 2, 2024

As above, please avoid merging until the issue has reached a generally acceptable consensus.

@drupol drupol marked this pull request as draft October 2, 2024 19:05
Nabile-Rahmani added a commit to Nabile-Rahmani/nixpkgs that referenced this pull request Oct 5, 2024
Should fix source builds by relying on our beloved archive.org to host a [SHA256-matching tarball generated from a mirror of the repo](https://archive.org/details/ryujinx-5dbba-07e-33e-83c-9047dcbb-701c-9655edbbe-89086.tar).

I have only `nix repl`'d the fetchTarball expression for its consistency check, as I do not currently have the time nor storage to build the package locally, sorry about that.

We could also generate archives to address NixOS#345410 and the 24.05 branch.

Supersedes: NixOS#345881
@Naxdy
Copy link
Contributor Author

Naxdy commented Oct 6, 2024

Closing due to #346694 being merged instead. Before reopening / opening a similar removal PR, refer to the discussion in #345758

@Naxdy Naxdy closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
5 participants