Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.mtcnn: init at 0.1.1; python3Packages.retinaface: init at 0.0.17; python3Packages.deepface: init at 0.0.92 #347052

Merged
merged 4 commits into from
Oct 9, 2024
Merged

python3Packages.mtcnn: init at 0.1.1; python3Packages.retinaface: init at 0.0.17; python3Packages.deepface: init at 0.0.92 #347052

merged 4 commits into from
Oct 9, 2024

Conversation

DerDennisOP
Copy link
Contributor

@DerDennisOP DerDennisOP commented Oct 7, 2024 •
edited
Loading

Things done

New PR for #331179
This PR will work as soon the tensorflow package is fixed. #314235

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@DerDennisOP DerDennisOP requested a review from natsukium as a code owner October 7, 2024 09:30
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 7, 2024
SuperSandro2000
SuperSandro2000 reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run , nixfmt 'pkgs/development/python-modules/mtcnn/default.nix'

pkgs/development/python-modules/retinaface/default.nix Show resolved Hide resolved
pkgs/development/python-modules/deepface/default.nix Show resolved Hide resolved
pkgs/development/python-modules/deepface/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/deepface/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit 8ff900b into NixOS:master Oct 9, 2024
22 checks passed
@dotlambda dotlambda mentioned this pull request Oct 27, 2024
Closed
12 tasks
@DerDennisOP DerDennisOP deleted the deepface2 branch December 30, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerDennisOP @SuperSandro2000