Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manga-ocr: 0.1.12 -> 0.1.13 #350050

Closed
wants to merge 2 commits into from
Closed

manga-ocr: 0.1.12 -> 0.1.13 #350050

wants to merge 2 commits into from

Conversation

Laurent2916
Copy link
Member

https://github.com/kha-white/manga-ocr

  • Moved the package to pkgs/by-name/
  • Updated to 0.1.13

Followup of #349961

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

DerDennisOP
DerDennisOP approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@DerDennisOP DerDennisOP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Laurent2916 Laurent2916 force-pushed the python3Packages.manga-ocr/0.1.12/0.1.13 branch from 7bcea4e to c47cfbc Compare October 20, 2024 18:57
@Laurent2916
Copy link
Member Author

Hi @DerDennisOP, thanks for the review!
I should probably keep myself better informed on deprecations and new best practices.

@DerDennisOP
Copy link
Contributor

Hi @DerDennisOP, thanks for the review! I should probably keep myself better informed on deprecations and new best practices.

now formatting is of, I dont like the new formatter but we gotta stick to it. please use the nix-fmt-rfc-style formatter to format your file

@teto
Copy link
Member

teto commented Oct 21, 2024

and the reference from python-modules should be removed

@Laurent2916 Laurent2916 force-pushed the python3Packages.manga-ocr/0.1.12/0.1.13 branch from c47cfbc to 10e12ee Compare October 27, 2024 20:21
DerDennisOP
DerDennisOP approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@DerDennisOP DerDennisOP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 28, 2024
FliegendeWurst
FliegendeWurst requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python modules should not be moved to pkgs/by-name.

@teto
Copy link
Member

teto commented Nov 8, 2024

Python modules should not be moved to pkgs/by-name.

why is that ? It's a python application here, if it makes any difference

@FliegendeWurst
Copy link
Member

why is that ? It's a python application here, if it makes any difference

It is both a library and an application (judging by the readme). In that case the module should stay in python-modules, but you can add a wrapper in pkgs/by-name.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@Laurent2916
Copy link
Member Author

Updated in #360641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst requested changes

@DerDennisOP DerDennisOP DerDennisOP approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Laurent2916 @DerDennisOP @teto @FliegendeWurst @wegank