Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster whisper update #350083

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Faster whisper update #350083

merged 2 commits into from
Oct 21, 2024

Conversation

happysalada
Copy link
Contributor

Faster whisper is broken on latest unstable because of incompatible av version.
I've upgraded wyoming-faster-whisper to latest version
and I've upgraded faster-whisper to latest git commit.
There seems to be some more improvements on top of the last release.
The biggest problem is the av version incompatibility. I've relaxed the dependency but didn't test further than build

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@happysalada happysalada requested a review from mweinelt October 20, 2024 19:02
@mweinelt mweinelt merged commit 65b41d1 into NixOS:master Oct 21, 2024
26 checks passed
@happysalada happysalada deleted the faster_whisper_update branch October 21, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants