Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prismlauncher: 8.4 -> 9.0 #350105

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Oct 20, 2024

Changelog: https://github.com/PrismLauncher/PrismLauncher/releases/tag/9.0
Diff: PrismLauncher/PrismLauncher@8.4...9.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo getchoo added the 11.by: upstream-developer This issue or PR was created by the developer of packaged software label Oct 20, 2024
@ofborg ofborg bot requested review from Scrumplex and Minion3665 October 21, 2024 00:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 21, 2024
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350105


x86_64-linux

✅ 2 packages built:
  • prismlauncher
  • prismlauncher-unwrapped

aarch64-linux

✅ 2 packages built:
  • prismlauncher
  • prismlauncher-unwrapped

x86_64-darwin

✅ 2 packages built:
  • prismlauncher
  • prismlauncher-unwrapped

aarch64-darwin

❌ 2 packages failed to build:
  • prismlauncher
  • prismlauncher-unwrapped

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350105


aarch64-darwin

✅ 2 packages built:
  • prismlauncher
  • prismlauncher-unwrapped

Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a transient failure with a test case. Should be good.

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 21, 2024
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as far as I can test.

@Aleksanaa Aleksanaa merged commit 1e09661 into NixOS:master Oct 21, 2024
32 of 33 checks passed
@getchoo getchoo deleted the pkgs/prismlauncher/9.0 branch October 21, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 11.by: upstream-developer This issue or PR was created by the developer of packaged software 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants