Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.passlib: fix passlib.pwd #351332

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

jackwilsdon
Copy link
Contributor

Fixes #351274.

Can be tested using the following command (fails on master):

$ nix-shell -p "(import ./. {}).python3.withPackages (pkgs: [ pkgs.passlib ])" --command "python -c 'import passlib.pwd; print(passlib.pwd.genword())'"

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@leona-ya
Copy link
Member

Can you please target staging with this PR (to avoid notifying everyone in case of a wrong merge please mark it as a draft before pushing and undraft it afterwards)

@jackwilsdon jackwilsdon marked this pull request as draft October 27, 2024 12:18
@jackwilsdon jackwilsdon changed the base branch from master to staging October 27, 2024 12:19
@jackwilsdon jackwilsdon marked this pull request as ready for review October 27, 2024 12:19
@jackwilsdon
Copy link
Contributor Author

jackwilsdon commented Oct 27, 2024

Didn't realise this would cause so many rebuilds - rebased onto staging.

@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 27, 2024
@dotlambda
Copy link
Member

This should actually target staging-next since it fixes pgadmin4.

@jackwilsdon jackwilsdon marked this pull request as draft October 27, 2024 18:02
@jackwilsdon jackwilsdon changed the base branch from staging to staging-next October 27, 2024 18:03
@jackwilsdon jackwilsdon marked this pull request as ready for review October 27, 2024 18:03
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge once @ofborg gives a green light.

@dotlambda dotlambda merged commit b8ff22d into NixOS:staging-next Oct 28, 2024
31 checks passed
@jackwilsdon jackwilsdon deleted the fix-passlib branch October 28, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pgadmin4 fails to start: No module named 'pkg_resources'
3 participants