doc/hooks/aws-c-common: init #351394
Merged
doc/hooks/aws-c-common: init #351394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: documentation
ofborg
bot
added
10.rebuild-darwin: 0
tomodachi94
force-pushed
the
create/doc/aws-c-common
branch
from
4e16b8e to
4aab178
Compare
r-burns
approved these changes
Nov 9, 2024
There was a problem hiding this comment.
Thank you for documenting this, looks good to me.
You could also point to the upstream issue that necessitated this change, if you like: awslabs/aws-c-common#844
This is a workaround for invalid upstream packaging of CMake modules, which might explain a bit better why we need this hook.
wegank
added
the
12.approvals: 1
tomodachi94
force-pushed
the
create/doc/aws-c-common
branch
from
4aab178 to
176eb0a
Compare
|
Oh interesting. Thanks for the backstory ❤️ I've made a note about it being a workaround, along with a link to the upstream issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #341479
Requesting a review from @r-burns (creator of the hook and package maintainer) and @orivej (package maintainer).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.