-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hal-hardware-analyzer: 4.2.0 -> 4.4.1 #353436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risicle
force-pushed
the
ris-hal-hardware-analyzer-4.4.1
branch
from
November 3, 2024 22:38
1a65cc6
to
ed102d4
Compare
ofborg
bot
added
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Nov 4, 2024
|
Looks like it's failing on aarch64-linux. 715 | a.val[1] = vrev64q_u16(a.val[1]);
| ~~~~~~~^
| |
| __Uint64x2_t
/nix/store/rsqi0h743vzhnmsby3rvxdqbcfbq3p6q-gcc-13.3.0/lib/gcc/aarch64-unknown-linux-gnu/13.3.0/include/arm_neon.h:20088:25: note: initializing argument 1 of 'uint16x8_t vrev64q_u16(uint16x8_t)'
20088 | vrev64q_u16 (uint16x8_t __a)
| ~~~~~~~~~~~^~~
/build/source/plugins/hawkeye/src/sbox_database.cpp: In function 'smallset_t hal::hawkeye::{anonymous}::smallset_init_full(u32)':
/build/source/plugins/hawkeye/src/sbox_database.cpp:868:56: error: cannot convert '__Uint64x2_t' to 'uint32x4_t'
868 | return {vsetq_lane_u32(0xFFFFFFFF, tmp, 0), vdupq_n_u64(0)};
| ^~~
| |
| __Uint64x2_t
/nix/store/rsqi0h743vzhnmsby3rvxdqbcfbq3p6q-gcc-13.3.0/lib/gcc/aarch64-unknown-linux-gnu/13.3.0/include/arm_neon.h:3018:45: note: initializing argument 2 of 'uint32x4_t vsetq_lane_u32(uint32_t, uint32x4_t, int)'
3018 | vsetq_lane_u32 (uint32_t __elem, uint32x4_t __vec, const int __index)
| ~~~~~~~~~~~^~~~~
/build/source/plugins/hawkeye/src/sbox_database.cpp:868:79: error: could not convert '{<expression error>, vdupq_n_u64(0)}' from '<brace-enclosed initializer list>' to 'smallset_t' {aka 'uint64x2x2_t'}
868 | return {vsetq_lane_u32(0xFFFFFFFF, tmp, 0), vdupq_n_u64(0)};
| ^
| |
| <brace-enclosed initializer list>
/build/source/plugins/hawkeye/src/sbox_database.cpp:877:52: error: cannot convert '__Uint64x2_t' to 'uint16x8_t'
877 | return {vsetq_lane_u16(0xFFFF, tmp, 0), vdupq_n_u64(0)};
| ^~~
| |
| __Uint64x2_t
/nix/store/rsqi0h743vzhnmsby3rvxdqbcfbq3p6q-gcc-13.3.0/lib/gcc/aarch64-unknown-linux-gnu/13.3.0/include/arm_neon.h:3011:45: note: initializing argument 2 of 'uint16x8_t vsetq_lane_u16(uint16_t, uint16x8_t, int)'
3011 | vsetq_lane_u16 (uint16_t __elem, uint16x8_t __vec, const int __index)
| ~~~~~~~~~~~^~~~~
/build/source/plugins/hawkeye/src/sbox_database.cpp:877:75: error: could not convert '{<expression error>, vdupq_n_u64(0)}' from '<brace-enclosed initializer list>' to 'smallset_t' {aka 'uint64x2x2_t'}
877 | return {vsetq_lane_u16(0xFFFF, tmp, 0), vdupq_n_u64(0)};
| ^
| |
| <brace-enclosed initializer list>
/build/source/plugins/hawkeye/src/sbox_database.cpp:886:49: error: cannot convert '__Uint64x2_t' to 'uint8x16_t'
886 | return {vsetq_lane_u8(0xFF, tmp, 0), vdupq_n_u64(0)};
| ^~~
| |
| __Uint64x2_t
/nix/store/rsqi0h743vzhnmsby3rvxdqbcfbq3p6q-gcc-13.3.0/lib/gcc/aarch64-unknown-linux-gnu/13.3.0/include/arm_neon.h:3004:43: note: initializing argument 2 of 'uint8x16_t vsetq_lane_u8(uint8_t, uint8x16_t, int)'
3004 | vsetq_lane_u8 (uint8_t __elem, uint8x16_t __vec, const int __index)
| ~~~~~~~~~~~^~~~~
/build/source/plugins/hawkeye/src/sbox_database.cpp:886:72: error: could not convert '{<expression error>, vdupq_n_u64(0)}' from '<brace-enclosed initializer list>' to 'smallset_t' {aka 'uint64x2x2_t'}
886 | return {vsetq_lane_u8(0xFF, tmp, 0), vdupq_n_u64(0)};
| ^
| |
| <brace-enclosed initializer list> |
also add verilator support
risicle
force-pushed
the
ris-hal-hardware-analyzer-4.4.1
branch
from
November 8, 2024 20:33
ed102d4
to
2a29ee7
Compare
Good spot. Addressed and reported upstream emsec/hal#598 |
|
khaneliman
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De-vendored
nlohmann_json
while I was at it.At least we can get rid of the special-cased
igraph
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.