Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.argcomplete: add patch to fix downstream issues #362121

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Dec 5, 2024

https://git.launchpad.net/ubuntu/+source/python-argcomplete/tree/debian/patches/python-3.13-compat.patch?h=ubuntu/plucky
https://bugs.launchpad.net/ubuntu/+source/python-argcomplete/+bug/2088928

fixes checkPhase of python3Packages.traitlets
https://hydra.nixos.org/build/281237249

kislyuk/argcomplete#513

#361878

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • test failure for python3Packages.traitlets fixed :)

@ofborg ofborg bot requested a review from womfoo December 6, 2024 09:52
@vcunat vcunat merged commit e4cc154 into NixOS:staging-next Dec 6, 2024
50 of 52 checks passed
@paparodeo paparodeo deleted the argcomplete-fixes branch December 6, 2024 11:08
@paparodeo
Copy link
Contributor Author

upstream fixed issue. updated and dropped patch for staging #362545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants