-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openexr: change default version from 2 to 3 #367406
base: master
Are you sure you want to change the base?
Conversation
b8fad00
to
834854f
Compare
834854f
to
7d85b17
Compare
7d85b17
to
785166a
Compare
@LeSuisse I've made a TODO list for all possible impacted packages (some are already on openexr_3). Should we backport everything according to you? |
Thanks <3 (I allowed myself to edit your post to mention some already existing PR) Yep we should backport everything that do not cause a behavior change since there are some unfixed security issues potentially impacting OpenEXR 2. |
Please do! |
@@ -10186,9 +10185,8 @@ with pkgs; | |||
|
|||
opencv = opencv4; | |||
|
|||
openexr = openexr_2; | |||
openexr_2 = callPackage ../development/libraries/openexr { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be an entry in top-level/aliases.nix
that throws an error upon accessing openexr_2
about the deprecation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And for ilmbase as well, as it is part of the same source tree and will get removed as well, right?
OpenEXR 2 is unmaintained, see NixOS#367406
9029854
to
c672902
Compare
@pluiedev as you're listed as maintainer of nzportable, just a heads-up: it declares to use openexr, but the configure phase of fteqw on master says it is not found. |
This one is peculiar, because they use their own version of openexr (a fork) that they have vendored through a submodule... which is of course vastly outdated, and probably very vulnerable too. I plan on opening an upstream issue, but should we mark pbrt as insecure? |
c672902
to
e18f1ba
Compare
Note : targeting master, because once #375774 is merged, I expect we will be below the threshold. |
Followup of #366939 to try to remove openexr v2 completely.
TODO:
all-packages.nix
)NOTE: check all-packages.nix because some package uses overrides for openexr
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.