Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openexr: change default version from 2 to 3 #367406

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

autra
Copy link
Contributor

@autra autra commented Dec 22, 2024

Followup of #366939 to try to remove openexr v2 completely.

TODO:

NOTE: check all-packages.nix because some package uses overrides for openexr

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@autra autra mentioned this pull request Dec 22, 2024
13 tasks
@autra autra changed the title gdal: switch to openexr_3 openexr: change default version from 2 to 3 Dec 24, 2024
@autra autra changed the base branch from master to staging December 24, 2024 14:14
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 24, 2024
@emilazy emilazy mentioned this pull request Jan 20, 2025
13 tasks
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 22, 2025
@nix-owners nix-owners bot requested review from basvandijk and hrdinka January 22, 2025 09:44
@autra
Copy link
Contributor Author

autra commented Jan 22, 2025

@LeSuisse I've made a TODO list for all possible impacted packages (some are already on openexr_3).

Should we backport everything according to you?

@LeSuisse
Copy link
Contributor

Thanks <3 (I allowed myself to edit your post to mention some already existing PR)

Yep we should backport everything that do not cause a behavior change since there are some unfixed security issues potentially impacting OpenEXR 2.

@autra
Copy link
Contributor Author

autra commented Jan 22, 2025

(I allowed myself to edit your post to mention some already existing PR)

Please do!

@@ -10186,9 +10185,8 @@ with pkgs;

opencv = opencv4;

openexr = openexr_2;
openexr_2 = callPackage ../development/libraries/openexr { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an entry in top-level/aliases.nix that throws an error upon accessing openexr_2 about the deprecation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And for ilmbase as well, as it is part of the same source tree and will get removed as well, right?

LeSuisse added a commit to LeSuisse/nixpkgs that referenced this pull request Jan 23, 2025
OpenEXR 2 is unmaintained, see NixOS#367406
@LeSuisse LeSuisse mentioned this pull request Jan 23, 2025
13 tasks
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 26, 2025
@autra
Copy link
Contributor Author

autra commented Jan 26, 2025

nzportable: openexr is referenced in nzportable's copy of fteqw, but the logs says "OpenExr not found" even on master. So something is wrong with this package build, but it's unrelated to this PR.

@pluiedev as you're listed as maintainer of nzportable, just a heads-up: it declares to use openexr, but the configure phase of fteqw on master says it is not found.

@autra
Copy link
Contributor Author

autra commented Jan 26, 2025

pbrt

This one is peculiar, because they use their own version of openexr (a fork) that they have vendored through a submodule... which is of course vastly outdated, and probably very vulnerable too. I plan on opening an upstream issue, but should we mark pbrt as insecure?

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jan 26, 2025
@autra autra changed the base branch from staging to master January 26, 2025 16:21
@github-actions github-actions bot removed 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jan 26, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 26, 2025
@autra
Copy link
Contributor Author

autra commented Jan 26, 2025

Note : targeting master, because once #375774 is merged, I expect we will be below the threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants