Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Label 10.rebuild-*-stdenv #369102

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Dec 29, 2024

Currently ofborg does this, but there is actually no real reason this shouldn't be done by CI

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dasJ dasJ requested review from Mic92 and infinisil December 29, 2024 12:30
Currently ofborg does this, but there is actually no real reason this
shouldn't be done by CI
@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Dec 29, 2024
@dasJ dasJ force-pushed the feat/label-stdenv-rebuild branch from e8c0d85 to 2c05e92 Compare December 29, 2024 12:30
@dasJ dasJ changed the title ci: Labl 10.rebuild-*-stdenv ci: Label 10.rebuild-*-stdenv Dec 29, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 29, 2024
dasJ added a commit to NixOS/ofborg that referenced this pull request Dec 29, 2024
@dasJ
Copy link
Member Author

dasJ commented Dec 29, 2024

Related: NixOS/ofborg#700

dasJ added a commit to NixOS/ofborg that referenced this pull request Dec 29, 2024
Copy link
Member

@RossComputerGuy RossComputerGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone from the stdenv team, I like this.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 30, 2024
dasJ added a commit to NixOS/ofborg that referenced this pull request Dec 30, 2024
@dasJ dasJ merged commit 6d96c9a into NixOS:master Dec 30, 2024
47 checks passed
@dasJ dasJ deleted the feat/label-stdenv-rebuild branch December 30, 2024 19:01
getchoo pushed a commit to getchoo-contrib/nixpkgs that referenced this pull request Jan 1, 2025
Currently ofborg does this, but there is actually no real reason this
shouldn't be done by CI

(cherry picked from commit 6d96c9a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants