Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

television: 0.7.1 -> 0.8.1 #369324

Merged
merged 1 commit into from
Dec 31, 2024
Merged

television: 0.7.1 -> 0.8.1 #369324

merged 1 commit into from
Dec 31, 2024

Conversation

louis-thevenet
Copy link
Contributor

Changelog: https://github.com/alexpasmantier/television/releases/tag/0.8.1
Diff: alexpasmantier/television@0.7.1...0.8.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@louis-thevenet louis-thevenet added the backport release-24.11 Backport PR automatically label Dec 30, 2024
@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369324

x86_64-linux

✅ 1 package built:
  • television

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 30, 2024
@louis-thevenet louis-thevenet added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 30, 2024
@lucasew
Copy link
Contributor

lucasew commented Dec 31, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369324

x86_64-linux

⏩ 5 packages marked as broken and skipped:
  • gnuk
  • kdePackages.umbrello
  • kdePackages.umbrello.debug
  • kdePackages.umbrello.dev
  • kdePackages.umbrello.devtools
⏩ 1 package blacklisted:
  • nixos-install-tools
❌ 16 packages failed to build:
  • affine
  • ananicy
  • clatd
  • ikiwiki-full
  • libretranslate (python312Packages.libretranslate)
  • libretranslate.dist (python312Packages.libretranslate.dist)
  • looking-glass-client
  • nanoboyadvance
  • python312Packages.ltpycld2
  • python312Packages.ltpycld2.dist
  • python313Packages.ltpycld2
  • python313Packages.ltpycld2.dist
  • schedtool
  • spike
  • tayga
  • weylus
✅ 86 packages built:
  • anydesk
  • apacheHttpdPackages.subversion
  • apacheHttpdPackages.subversion.dev
  • apacheHttpdPackages.subversion.man
  • armTrustedFirmwareTools
  • biboumi
  • bonsai
  • cabal2nix
  • circt
  • circt.dev
  • circt.lib
  • dnsdbq
  • easytier
  • fusee-launcher
  • gdu
  • git-doc (git-doc.debug ,git-doc.doc ,gitFull.doc)
  • gitFull
  • gitFull.debug
  • gitSVN
  • gitSVN.debug
  • gitSVN.doc
  • hareThirdParty.hare-ev
  • hydra
  • hydra.doc
  • kdePackages.kdev-php
  • kdePackages.kdev-php.debug
  • kdePackages.kdev-php.dev
  • kdePackages.kdev-php.devtools
  • kdePackages.kdev-python
  • kdePackages.kdev-python.debug
  • kdePackages.kdev-python.dev
  • kdePackages.kdev-python.devtools
  • kdePackages.kdevelop
  • kdePackages.kdevelop.debug
  • kdePackages.kdevelop.dev
  • kdePackages.kdevelop.devtools
  • kdesvn
  • klipper-firmware
  • klipper-flash
  • lazyjournal
  • lgogdownloader
  • livekit-libwebrtc
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mangojuice
  • nitrokey-trng-rs232-firmware
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-update-source
  • nix-update-source.dist
  • obs-do
  • opencomposite
  • owmods-cli
  • patroni
  • patroni.dist
  • perl538Packages.SVNSimple
  • perl538Packages.SVNSimple.devdoc
  • perl540Packages.SVNSimple
  • perl540Packages.SVNSimple.devdoc
  • pkgsite
  • python312Packages.pysvn
  • ydiff (python312Packages.ydiff)
  • ydiff.dist (python312Packages.ydiff.dist)
  • python313Packages.pysvn
  • python313Packages.ydiff
  • python313Packages.ydiff.dist
  • qmk
  • qmk.dist
  • rapidsvn
  • simavr
  • slackdump
  • subversion
  • subversion.dev
  • subversion.man
  • subversionClient
  • subversionClient.dev
  • subversionClient.man
  • svn-all-fast-export
  • svn2git
  • svnfs
  • television
  • thcrap-steam-proton-wrapper
  • vcstool
  • vcstool.dist
  • wp4nix
  • zed-editor

@ddogfoodd
Copy link
Contributor

Why is your nixpkgs-review result so much different to mine?

@misuzu misuzu merged commit 2e6f322 into NixOS:master Dec 31, 2024
45 of 46 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 31, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 31, 2024
Merged
1 task
@lucasew
Copy link
Contributor

lucasew commented Dec 31, 2024

Why is your nixpkgs-review result so much different to mine?

I was trying to debug that. It seems like a zfs eventual consistency issue. I added sync calls around the nixpkgs-review in my pipeline

I am queueing up nixpkgs-review to run overnight in my machine using ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddogfoodd ddogfoodd ddogfoodd approved these changes

@misuzu misuzu misuzu approved these changes

@getchoo getchoo Awaiting requested review from getchoo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@louis-thevenet @ddogfoodd @lucasew @misuzu @wegank