Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Mobilizon 5.1.1 forgot to bump their internal version, which causes issues with static file serving in the Mobilizon NixOS module as it relies on Nix and internal package versions being the same:
nixpkgs/nixos/modules/services/web-apps/mobilizon.nix
Lines 439 to 440 in 88195a9
This PR temporarily replaces the version in the hopes that the next version of Mobilizon does not repeat this. If this becomes a recurring issue, we might want to consider always setting the version in
mix.exs
to the Nix package version.I didn't catch this in the 5.1.1 update PR unfortunately because all static files were cached already when I was testing the update on rheinneckar.events.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.