-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catboost: tweak, fix build #370663
catboost: tweak, fix build #370663
Conversation
Signed-off-by: lucasew <lucas59356@gmail.com>
|
@lucasew Would you be able to fix the failures ? Please, ping me if you need the logs. |
Working on that |
The rabbit hole is much deeper than I expected |
|
Try to |
It didn't work BTW catboost seems to work. I think I will deliver this first and deal with the python package in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, fine by me, let's merge this !
FWIW this uses CUDA 11 which is scheduled for removal from 25.05. It’s probably worth trying to bump it to CUDA 12 if there’s interest in keeping it working. |
This is a dependency of orange3. Merging this would fix orange3 by consequence.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.