Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtox: 1.17.6 -> 1.18.0, switch to TokTok fork #370832

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jan 4, 2025

The original qTox is unmaintained, the repo is archived since Feb 2023.

Upstream warns about unofficial forks, however:

  • TokTok are the maintainers of toxcore
  • qtox.meta.homepage was set to tox.chat and the TokTok fork is listed in the tox.chat client list

This also unbreaks the package, which is also broken on stable, so I added the backport label.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fgaz fgaz added the backport release-24.11 Backport PR automatically label Jan 4, 2025
@fgaz fgaz force-pushed the qtox/toktok branch 2 times, most recently from 89da14b to bc61f3a Compare January 4, 2025 11:47
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 4, 2025
@nix-owners nix-owners bot requested review from akaWolf and peterhoeg January 4, 2025 11:49
Copy link
Contributor

@MatthewCroughan MatthewCroughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and the tox.chat website refers to this TokTok fork now.

The original qTox is unmaintained, the repo is archived since Feb 2023.

Upstream warns about unofficial forks, however:

* TokTok are the maintainers of toxcore
* qtox.meta.homepage was set to tox.chat and
  the TokTok fork is listed in the tox.chat client list
@fgaz fgaz merged commit 3c4f91e into NixOS:master Jan 12, 2025
22 checks passed
@fgaz fgaz deleted the qtox/toktok branch January 12, 2025 14:25
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Jan 12, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants