staging-next 2025-01-06 #371501
Open
staging-next 2025-01-06 #371501
+18,911
−10,996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onflict-1735949935
See a0919c7 for rationale.
This matches the default configuration of ICU upstream. Otherwise, some packages (such as Boost) fail to build against darwin.ICU. This should be safe ABI-wise because (according to the comments), char16_t and uint16_t have the same memory representation. The reason why Apple did not make the change is due to a build failure in one of their proprietary frameworks when using char16_t.
The ICU C++ API is not ABI stable. Since ICU is normally shipped as a system library, Apple has disabled it by default. This breaks using ICU as the default implementation on Darwin in nixpkgs because packages expect to use the C++ API without having to opt into it. This change enables the C++ API by default based on the assumption that the packages using it in nixpkgs are built from source, and any binaries that would link against `libicucore.B.dylib` won’t be using the C++ API and should not suffer from ABI problems, and if they did use the C++ API, they would have ABI problems regardless because the symbols are still present in the ICU dylibs.
|
I've tried building my home-manager with commit e022056 config on darwin-aarch64 (not sure why, but hope this helps), and nix log |
Closed
https://github.com/googlefonts/ufo2ft/releases/tag/v3.3.1 https://github.com/googlefonts/ufo2ft/releases/tag/v3.4.0 The dropped patch was already included in >= 3.3.1. This update fixes its tests; not sure what broke it in staging*: https://hydra.nixos.org/build/285244879/nixlog/2/tail
The build process received signal 9 (SIGKILL), so the machine probably ran out of memory. Update: builds fine for me on aarch64-darwin. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/systemd-version-in-unstable-lower-than-stable/58739/6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful links
https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
https://hydra.nixos.org/job/nixos/staging-next-small/tested
https://hydra.nixos.org/jobset/nixpkgs/staging-next
https://hydra.nixos.org/jobset/nixos/staging-next-small
Important breakages
nixosTests.containers-imperativebelow