Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/request-reviews: Fix code owner requests for filenames with spaces #372433

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

infinisil
Copy link
Member

Discovered in #368656 (comment)

Ping @SigmaSquadron

Things done

  • Tested get-code-owners.sh locally with a commit that changes a file with a filename that has a space

This work is funded by Tweag and Antithesis

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Jan 9, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 9, 2025
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 9, 2025
@infinisil infinisil merged commit 2b536d0 into NixOS:master Jan 9, 2025
26 of 30 checks passed
@infinisil infinisil deleted the fix-code-owners-space-files branch January 9, 2025 19:00
@wolfgangwalther wolfgangwalther added the backport release-24.11 Backport PR automatically label Jan 11, 2025
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Jan 11, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants