dotnet: implement autoPatchcilHook #373107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGG-KILLER
changed the title
github-actions
bot
added
8.has: documentation
nix-owners
bot
requested review from
hsjobeki,
GetPsyched,
corngood and
fricklerhandwerk
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new tool called
patchcilwhich aims to be the CIL (.NET's intermediate language) equivalent ofpatchelf.Also implements a new hook called
autoPatchcilHookwhich uses thepatchciltool to rewrite all static (read:[DllImport]-based) native library uses to point to the correct location in the nix store.Finally, rewrites
avalonia-ilspyto useautoPatchcilHookas a (rather extreme, as it uses quite a few Xorg libraries, GTK 3 and OpenGL) test case.cc: @NixOS/dotnet @js6pak @AngryAnt @emilytrau
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.