-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mattermostLatest: init at 10.3.1 #373113
base: master
Are you sure you want to change the base?
mattermostLatest: init at 10.3.1 #373113
Conversation
7adc08b
to
e7f7bea
Compare
e7f7bea
to
423c6d7
Compare
423c6d7
to
4a1fadc
Compare
@fsagbuya No changes were necessary for this to get it working |
4a1fadc
to
a2cb514
Compare
|
LGTM. :) |
Looks like an empty result? In any case I think it's just a |
Package built. Can EDIT: Okay, I think you already mentioned that in the description. Otherwise, I'm good with this PR. Nice! |
It will be in #208181, but I manually replaced pkgs.mattermost with pkgs.mattermostLatest and they all passed. #208181 changes the module enough (in a backwards compatible way, but a way that affects the tests nonetheless) that it's probably not worth casing out the tests in this PR. I've not pushed up the changes just yet but it starts with Mattermost ESR and then switches to a config specialization that switches to mattermostLatest to make sure migrations work. |
Create
mattermostLatest
to pull in the latest Mattermost. This works fine with all the NixOS tests, but that won't be PRed here. Instead, we will do it in #208181 which will not be backported. If people choose the latest Mattermost, they are accepting a little less stability (in general, but especially for now).Depends-on: #373085
Backport label this since it affects the autoupdate.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.