Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mattermostLatest: init at 10.3.1 #373113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Jan 12, 2025

Create mattermostLatest to pull in the latest Mattermost. This works fine with all the NixOS tests, but that won't be PRed here. Instead, we will do it in #208181 which will not be backported. If people choose the latest Mattermost, they are accepting a little less stability (in general, but especially for now).

Depends-on: #373085

Backport label this since it affects the autoupdate.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jan 12, 2025
@numinit numinit requested a review from fsagbuya January 12, 2025 04:37
@numinit numinit added the backport release-24.11 Backport PR automatically label Jan 12, 2025
@numinit numinit force-pushed the mattermost/latest branch 2 times, most recently from 7adc08b to e7f7bea Compare January 13, 2025 07:34
@github-actions github-actions bot removed the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jan 13, 2025
@numinit numinit marked this pull request as ready for review January 13, 2025 07:45
@numinit
Copy link
Contributor Author

numinit commented Jan 13, 2025

@fsagbuya No changes were necessary for this to get it working

@numinit numinit requested a review from drupol January 13, 2025 07:55
@fsagbuya
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373113

@fsagbuya
Copy link
Contributor

LGTM. :)

@numinit
Copy link
Contributor Author

numinit commented Jan 13, 2025

Looks like an empty result? In any case I think it's just a nix-build -A mattermostLatest

@fsagbuya
Copy link
Contributor

fsagbuya commented Jan 13, 2025

Looks like an empty result? In any case I think it's just a nix-build -A mattermostLatest

nix-build -A mattermostLatest && ls -lhLS result/
/nix/store/zspzwzcf4mvq44szgchvvah3xl1qzb0k-mattermost-10.3.1
total 52K
dr-xr-xr-x 8 root root  28K Jan  1  1970 client
dr-xr-xr-x 2 root root 4.0K Jan  1  1970 bin
dr-xr-xr-x 2 root root 4.0K Jan  1  1970 config
dr-xr-xr-x 2 root root 4.0K Jan  1  1970 fonts
dr-xr-xr-x 2 root root 4.0K Jan  1  1970 i18n
dr-xr-xr-x 3 root root 4.0K Jan  1  1970 templates

Package built. Can nixosTests.mattermost be applied to this as well?

EDIT: Okay, I think you already mentioned that in the description. Otherwise, I'm good with this PR. Nice!

@numinit
Copy link
Contributor Author

numinit commented Jan 13, 2025

It will be in #208181, but I manually replaced pkgs.mattermost with pkgs.mattermostLatest and they all passed. #208181 changes the module enough (in a backwards compatible way, but a way that affects the tests nonetheless) that it's probably not worth casing out the tests in this PR.

I've not pushed up the changes just yet but it starts with Mattermost ESR and then switches to a config specialization that switches to mattermostLatest to make sure migrations work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants