python312Packages.stable-baselines3: 2.4.0 -> 2.4.1-unstable-2025-01-07 #373253
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NickCao
reviewed
Jan 12, 2025
There was a problem hiding this comment.
numpy 2 is supported on master: DLR-RM/stable-baselines3@daaebd0, maybe bump to an unstable version?
GaetanLepage
force-pushed
the
stable-baselines3
branch
from
011805c to
d82f680
Compare
GaetanLepage
changed the title
Yes good idea. Done |
GaetanLepage
force-pushed
the
stable-baselines3
branch
from
d82f680 to
cfb726e
Compare
|
| @@ -22,14 +22,16 @@ | |||
| }: | |||
| buildPythonPackage rec { | |||
| pname = "stable-baselines3"; | |||
| version = "2.4.0"; | |||
| # TODO: To this date, the latest release is not compatible with numpy 2 | |||
| version = "2.4.1-unstable-2025-01-07"; | |||
There was a problem hiding this comment.
Why then don't stay on 2.4.1?
There was a problem hiding this comment.
No, that's the point. 2.4.1 doesn't ship numpy 2 compatibility.
I rephrased the comment. It's clearer now hopefully.
GaetanLepage
force-pushed
the
stable-baselines3
branch
from
cfb726e to
617a55a
Compare
natsukium
approved these changes
Jan 14, 2025
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Changelog: https://github.com/DLR-RM/stable-baselines3/releases/tag/v2.4.1
cc @DerDennisOP
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.