Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Backport release-24.11] nixos/alsa: rebirth from the ashes" #373263

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 12, 2025

Reverts #371385

Rationales for revert:

  • First of all, this is a breaking change as outlined by @fpletz: nixos/alsa: rebirth from the ashes #337345 (comment). To quote our contribution guidelines:

    The release branches should generally only receive backwards-compatible changes, both for the Nix expressions and derivations

    I don't see a missed deadline (no matter who's at fault) as sufficiently pressing reason to overrule this.

  • Second, nobody reads the 24.11 release notes after having upgraded to 24.11, so this is pretty questionable.

Whether or not to revert on master is still to be discussed as brought up in #337345. At least the 24.11 release notes require a fix-up.

cc @fpletz @emilazy @winterqt @rnhmjoj

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 12, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 12, 2025
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The module can be eventually reintroduced without breaking changes.

@SigmaSquadron SigmaSquadron added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 12, 2025
@Ma27
Copy link
Member Author

Ma27 commented Jan 13, 2025

Given two approvals including from the original author I'll merge now.

@Ma27 Ma27 merged commit fc1a4f4 into release-24.11 Jan 13, 2025
25 checks passed
@Ma27 Ma27 deleted the revert-371385-backport-337345-to-release-24.11 branch January 13, 2025 06:11
@Ma27
Copy link
Member Author

Ma27 commented Jan 13, 2025

The release notes also require adjustment on master, i.e. to have correct instructions in 25.05. Do you plan to take care of this @rnhmjoj?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 13, 2025

I guess you can revert the PR on master for now: I'll make a new one with release notes for 25.05.
I'm thinking about leaving hardware.alsa.enablePersistence and starting a new ALSA module under a different namespace, like programs.alsa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants