Revert "[Backport release-24.11] nixos/alsa: rebirth from the ashes" #373263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #371385
Rationales for revert:
First of all, this is a breaking change as outlined by @fpletz: nixos/alsa: rebirth from the ashes #337345 (comment). To quote our contribution guidelines:
I don't see a missed deadline (no matter who's at fault) as sufficiently pressing reason to overrule this.
Second, nobody reads the 24.11 release notes after having upgraded to 24.11, so this is pretty questionable.
Whether or not to revert on master is still to be discussed as brought up in #337345. At least the 24.11 release notes require a fix-up.
cc @fpletz @emilazy @winterqt @rnhmjoj