Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.11] zammad: apply fix for ZAA-2024-05 #373275

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

NetaliDev
Copy link
Member

Patch for ZAA-2024-05 for Zammad as suggested by @LeSuisse in #372724.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NetaliDev NetaliDev added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 12, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 12, 2025
@nix-owners nix-owners bot requested review from Radvendii and n0emis January 12, 2025 20:23
@NetaliDev NetaliDev requested a review from LeSuisse January 12, 2025 20:28
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I got conflicts when I tried to cherry-pick manually I did not thought the patch could be applied directly.

Builds and test succeeds on Linux x86_64. A bunch of logging is done during the test and it looks fine.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373275


x86_64-linux

✅ 1 package built:
  • zammad

@LeSuisse LeSuisse merged commit a49f26a into NixOS:release-24.11 Jan 13, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants