lvm2: put the profile scripts into etc/profile.d

[7c6f434c]

Motivation: #369732

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside [nixos/tests](https:// github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nix-owners]

The PR's base branch is set to master, but 1149 commits from the staging branch are included. Make sure you know the right base branch for your changes, then:

• If the changes should go to the staging branch, change the base branch to staging
• If the changes should go to the master branch, rebase your PR onto the merge base with the master branch:

  # git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/staging HEAD)
  git rebase --onto 93dbaf6d1a0385b5a7d9b378db1176b76db622fd e290d236884088ae2f61432eb72b5229ebf0404d
  git push --force-with-lease

[wolfgangwalther]

You still seem to have 11 commits from another branch in this PR. I suggest you rebase interactively and drop them - those are probably commits that were on master already, but didn't make their way to staging at the time, yet.

[7c6f434c]

It looks like profile is never mentioned in the same file as lvm2 in the context of etc/profile path (but I am trying to run the tests just in case)

[7c6f434c]

Separated reformatting, fixed the reference to tests, asked the original reporter of the bug about how to check if the bug is fixed,

[7c6f434c]

The following is broken on master but works here:

buildFHSEnv {
  name="test"; 
  targetPkgs=p: with p; [lvm2];
}

[wolfgangwalther]

The following is broken on master but works here:

Confirmed. The resulting -test-fhsenv-rootfs folder structure seems better with profile.d than only with profile.

I did a stupid rg 'etc/profile' -C1000 | rg lvm2 and didn't get any matches. Not a proof, but at least an indication.

[7c6f434c]

Build failure — an unrelated dependency timeout.

Apparently the fourth commit causes GHA to break down workflow generation??

[wolfgangwalther]

Apparently the fourth commit causes GHA to break down workflow generation??

Funny times :D

[wolfgangwalther]

I think there's some general hiccups with GHA again, looking at the failures on https://github.com/NixOS/nixpkgs/actions

[7c6f434c]

Do they shard by commit hash and some of the shards are broken? (Trying to make sense that rolling back kind of helped)

[wolfgangwalther]

Do they shard by commit hash and some of the shards are broken? (Trying to make sense that rolling back kind of helped)

Interesting idea. In that case amending the commit without changes to get a different hash should help.

[7c6f434c]

Which I did by rewriting a commit message, which seems to have helped…

GHAcoin: rewrite the commit message until your hash hits a good shard!

[wolfgangwalther]

Yeah, worked for me elsewhere, too :D