Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.facedancer: 3.0.6 -> 3.1.0 #373393

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

carlossless
Copy link
Contributor

@carlossless carlossless commented Jan 13, 2025

Same changes as #373366, just with the minimum python version changed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@carlossless carlossless changed the title <!-- ^ Please summarise the changes you have done and explain why they are necessary here ^ python312Packages.facedancer: 3.0.6 -> 3.1.0 Jan 13, 2025
@carlossless
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373393


x86_64-linux

✅ 4 packages built:
  • python312Packages.facedancer
  • python312Packages.facedancer.dist
  • python313Packages.facedancer
  • python313Packages.facedancer.dist

aarch64-linux

✅ 4 packages built:
  • python312Packages.facedancer
  • python312Packages.facedancer.dist
  • python313Packages.facedancer
  • python313Packages.facedancer.dist

x86_64-darwin

✅ 4 packages built:
  • python312Packages.facedancer
  • python312Packages.facedancer.dist
  • python313Packages.facedancer
  • python313Packages.facedancer.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.facedancer
  • python312Packages.facedancer.dist
  • python313Packages.facedancer
  • python313Packages.facedancer.dist

@carlossless carlossless marked this pull request as ready for review January 13, 2025 09:58
@NickCao NickCao merged commit b7a036f into NixOS:master Jan 13, 2025
83 of 86 checks passed
@carlossless carlossless deleted the package/facedancer branch January 13, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants