binwalk: add missing dependencies & versionCheckHook #373404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
felbinger
approved these changes
Jan 13, 2025
pkgs/by-name/bi/binwalk/package.nix
Outdated
| @@ -18,16 +45,42 @@ rustPlatform.buildRustPackage rec { | |||
| repo = "binwalk"; | |||
| tag = "v${version}"; | |||
| hash = "sha256-em+jOnhCZH5EEJrhXTHmxiwpMcBr5oNU1+5IJ1H/oco="; | |||
| fetchSubmodules = true; | |||
There was a problem hiding this comment.
The repo contains no .gitmodules file. Why do we need this?
There was a problem hiding this comment.
Oh, I see. I wasn't sure what modules it fetched, thought it was some rust ones and wanted to get all the optional ones. Gitmodules makes more sense.
wegank
added
12.approvals: 1
Do we upload the lockfiles into nixpkgs now? since I still saw packages removing them and using useFetchCargoVendor, or I'm not sure I quite understand the sentence correctly. |
wegank
removed
the
12.approvals: 1
|
@KSJ2000 srec2bin has been merged, so after a rebase it should be possible to also add this package. |
felbinger
approved these changes
Jan 15, 2025
SuperSandro2000
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.