Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

klick: fix cross build #373479

Merged
merged 1 commit into from
Jan 15, 2025
Merged

klick: fix cross build #373479

merged 1 commit into from
Jan 15, 2025

Conversation

FliegendeWurst
Copy link
Member

Also fixes regular strictDeps build, ref. #178468

Previously failed https://paste.fliegendewurst.eu/yepvbd.log

Things done

  • Built on platform(s)
    • x86_64-linux: and cross to aarch64
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 13, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 13, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 14, 2025
@sikmir
Copy link
Member

sikmir commented Jan 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373479

x86_64-linux

✅ 1 package built:
  • klick

nix build -L .#pkgsCross.armv7l-hf-multiplatform.klick is OK.

@sikmir sikmir merged commit f7a9687 into NixOS:master Jan 15, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uninsane uninsane uninsane approved these changes

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FliegendeWurst @sikmir @uninsane @wegank