-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py-solc: init at 3.2.0 #48323
py-solc: init at 3.2.0 #48323
Conversation
@GrahamcOfBorg build python3Packages.py-solc |
Success on x86_64-darwin (full log) Attempted: python3Packages.py-solc Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: python3Packages.py-solc Partial log (click to expand)
|
No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled. |
Success on aarch64-linux (full log) Attempted: python3Packages.py-solc Partial log (click to expand)
|
@FRidh Disabling tests for now, since I can't get them running. Created an issue for that: ethereum/py-solc#60 |
|
||
meta = with lib; { | ||
description = "Python wrapper around the solc binary"; | ||
license = licenses.mit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add homepage = "https://github.com/ethereum/py-solc";
Looks like they're not maintaining it anymore: ethereum/py-solc#65 (comment) But he created a fork. Maybe you'd want to package that instead. |
I will not need this one anymore. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)