Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmw: 0.43 -> 0.44 #57493

Merged
merged 2 commits into from
Mar 14, 2019
Merged

openmw: 0.43 -> 0.44 #57493

merged 2 commits into from
Mar 14, 2019

Conversation

marius851000
Copy link
Contributor

@marius851000 marius851000 commented Mar 12, 2019 •
edited by veprbl
Loading

Motivation for this change

openmw is outdated

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Resolves: #46153
Resolves: #55760

@GrahamcOfBorg GrahamcOfBorg requested a review from abbradar March 12, 2019 07:48
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 12, 2019
@peterhoeg
Copy link
Member

openmw is still using qt4 - feel like taking a stab at moving it to qt5?

@marius851000
Copy link
Contributor Author

marius851000 commented Mar 12, 2019 •
edited
Loading

qt5 is not enabled by default. I added it to the build procedure (that also add cool transparent menu with kvantum). I made it optionnal, but enabled it by default

@veprbl
Copy link
Member

veprbl commented Mar 12, 2019

Number of openmw bumps is getting a bit out of hand: #46153 #55760
Need to merge one already.

@peterhoeg
Copy link
Member

Number of openmw bumps is getting a bit out of hand

Indeed - let's get this one past the goal post and we can close the others.

@veprbl
Copy link
Member

veprbl commented Mar 14, 2019

@GrahamcOfBorg build openmw

veprbl
veprbl approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built on NixOS, tested executables without data files

@veprbl veprbl merged commit 9034847 into NixOS:master Mar 14, 2019
@veprbl veprbl mentioned this pull request Mar 30, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg peterhoeg left review comments

@veprbl veprbl veprbl approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marius851000 @peterhoeg @veprbl @GrahamcOfBorg