Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up our environment in the binstub #2

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

michaelglass
Copy link

@michaelglass michaelglass commented Oct 5, 2020

another approach for #1

should outfox rails#626

paired with @BrianHicks

when we have a big environment, we sometimes get "argument list too long errors"

how to repro:

  1. add a really long environmental variable prefixed with NIX_
  2. in one terminal, run spring server (so you can easily see debug info, there's another way but you have to read the docs for that one)
  3. in another terminal run, rails c

without this binstub: argument errors!!!
with this binstub: no errors, your life is a good life full of meaning

@BrianHicks
Copy link

works fine for me too! 🎉

@BrianHicks BrianHicks requested a review from asterite October 5, 2020 15:25
@michaelglass
Copy link
Author

@asterite can you release this as a new version?

@asterite
Copy link

asterite commented Oct 6, 2020

Sure! And I'll send a PR to the monolith with the new version.

@asterite asterite merged commit 0ba51b9 into master Oct 6, 2020
@asterite asterite deleted the shrink-environment-part-deux branch October 6, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants