Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add coach class rating #73

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

NodeJSmith
Copy link
Owner

@NodeJSmith NodeJSmith commented Jan 22, 2025

  • add functionality to rate a class
  • add exceptions for new method
  • don't log exception when re-raising OtfRequestError, to avoid logging errors that we will be reframing/changing
  • rename performance summary entry/detail id attribute to class_history_uuid
  • add method for getting a performance summary entry from a class_history_uuid, since this model is the only one that has all the pieces to rate a class

…eption to OtfRequestError

feat(exceptions.py): add original_exception attribute to OtfRequestError for better error context
…ry_uuid instead of id for clarity

refactor(performance_summary_detail.py): rename id to class_history_uuid for better semantic meaning and consistency

refactor(performance_summary_list.py): rename id to class_history_uuid for improved clarity and consistency

fix(performance_summary_detail.py): exclude and hide ratable field due to inaccuracy in reflecting data from PerformanceSummaryEntry
Introduce methods to rate classes and coaches based on performance
summaries. This includes handling exceptions for already rated or
non-ratable classes, enhancing user interaction with the app.

docs(examples): add example for rating a class

Provide a usage example for the new class rating feature, demonstrating
how to rate a class and handle the response.

fix(exceptions): add specific exceptions for rating errors

Introduce AlreadyRatedError and ClassNotRatableError to handle specific
cases when rating classes, improving error handling and clarity.
@NodeJSmith NodeJSmith merged commit 287d45f into main Jan 22, 2025
4 checks passed
@NodeJSmith NodeJSmith deleted the feature/add_coach_class_rating branch January 22, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant