Retry when an async slotmap update fails #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat an empty ip string as it means the same endpoint the current command was sent to, as described in docs. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Treat an empty ip string as it means the same endpoint the current command was sent to, as described in docs. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Treat an empty ip string as it means the same endpoint the current command was sent to, as described in docs. Use the host address that is kept in the hiredis context. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Treat an empty ip string as it means the same endpoint the current command was sent to, as described in docs. Use the host address from the hiredis context. Remove duplicate validation of host and port elements. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
The added flag --async-initial-update allows testcases to connect to the cluster using `redisClusterAsyncConnect2`, which will not block while performing the initial slotmap update. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
…sync-initial-update-fix
Since timers are handled before filedescription events in libevent we will not give time to socket reads when sending multiple commands. Using a short time allows hiredis to read from sockets and avoids some unpredictability in tests. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
"A NULL value for the endpoint indicates the node has an unknown endpoint and the client should connect to the same endpoint it used to send the CLUSTER SLOTS command but with the port returned from the command." Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes A question about
redisClusterAsyncConnect2()and slot map updates #249 .Additional related corrections found while testing:
CLUSTER SLOTSandCLUSTER NODESresponses.Treat an empty ip string as it means the same endpoint the current command was sent to, as described in docs.
Use the host address that is kept in the hiredis context.
This solves the problem that an empty address was accepted, despite connecting using and empty address will fail in the next slotmap update.
CLUSTER SLOTSresponses.Test improvements:
Add
connect-during-cluster-startuptests.Two new tests were added to verify that the slotmap will be be updated until it succeed.
clusterclient_asyncreceived a new flag--async-initial-updateto be able to connect toan cluster using
redisClusterAsyncConnect2, which will not block while performing the initial slotmap update.Use short timeout when scheduling processing of next command in
clusterclient_async.