Fix hiredis_cluster_ssl build on Windows #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjosv
requested changes
Jan 15, 2025
This reverts commit a8bf8d4.
This can be done since hiredis_cluster.def is no longer a limitation
|
Ended up doing a bit more (enabling the non-const connect cb API on windows) when searching for references to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because hiredis_cluster_ssl does not export any functions, building it on Windows produces just the .dll and not the .lib file (this stackoverflow question describes a similar problem).
Made changes that mirror what is done for hiredis_cluster (adding a .def file with the exports for the WIN32 build)