Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ember-source to 5.10 #1787

Merged
merged 10 commits into from
Aug 7, 2024
Merged

Upgrade ember-source to 5.10 #1787

merged 10 commits into from
Aug 7, 2024

Conversation

NullVoxPopuli
Copy link
Owner

Let's see if we can replicate or resolve emberjs/ember.js#20718

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jul 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NullVoxPopuli NullVoxPopuli mentioned this pull request Jul 9, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

Project Preview URL1 Manage
Limber https://ember-source-5-10.limber-glimdown.pages.dev on Cloudflare
Tutorial https://ember-source-5-10.limber-glimmer-tutorial.pages.dev on Cloudflare

Logs

Footnotes

  1. if these branch preview links are not working, please check the logs for the commit-based preview link. There is a character limit of 28 for the branch subdomain, as well as some other heuristics, described here for the sake of implementation ease in deploy-preview.yml, that algo has been omitted. The URLs are logged in the wrangler output, but it's hard to get outputs from a matrix job. ↩

NullVoxPopuli
NullVoxPopuli commented Jul 9, 2024
View reviewed changes
packages/app-support/limber-ui/addon/package.json Outdated
@@ -38,7 +38,8 @@
"ember-modifier": "^4.1.0",
"ember-primitives": ">= 0.11.0",
"ember-resources": ">= 6.4.2",
"ember-source": ">= 5.9.0"
"ember-source": ">= 5.10.0",
"webpack": "^5.92.1"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding webpack as a peer here to "forward" ember-source's peer resolves the peer issues embroider is telling us about (duplicate ember-sources)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels super gross though, and I've asked about it here https://discord.com/channels/480462759797063690/568935504288940056/1260033731918299136

NullVoxPopuli
NullVoxPopuli commented Jul 9, 2024
View reviewed changes
apps/repl/ember-cli-build.js Outdated
// Adds:
// - ember-template-compiler
// - @glimmer/syntax
app.import('vendor/ember/ember-template-compiler.js');
Copy link
Owner Author

@NullVoxPopuli NullVoxPopuli Jul 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this appears to not be required anymore -- presumably because:

  • ef4 keeps chugging away at ember-source modernizations, making the template compiler findable by our build tooling
  • I have no idea how this vendor/ember thing ever resolved in the first place, looking through source, it existed at dist/ember-template-compiler.js (looks to be some configamahwhoozits in lib/index.js)

@NullVoxPopuli NullVoxPopuli merged commit ba4b8b0 into main Aug 7, 2024
8 of 9 checks passed
@NullVoxPopuli NullVoxPopuli deleted the ember-source-5-10 branch August 7, 2024 12:17
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[5.10] Can't import the template-compiler
1 participant
@NullVoxPopuli