-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] account_fiscal_product_rule #305
Changes from all commits
36eb62b
0d9218e
2fd3dc9
b9b6906
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
=========================== | ||
Account Fiscal Product Rule | ||
=========================== | ||
|
||
.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
!! This file is generated by oca-gen-addon-readme !! | ||
!! changes will be overwritten. !! | ||
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png | ||
:target: https://odoo-community.org/page/development-status | ||
:alt: Beta | ||
.. |badge2| image:: https://img.shields.io/badge/licence-LGPL--3-blue.png | ||
:target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html | ||
:alt: License: LGPL-3 | ||
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Faccount--fiscal--rule-lightgray.png?logo=github | ||
:target: https://github.com/OCA/account-fiscal-rule/tree/14.0/account_fiscal_product_rule | ||
:alt: OCA/account-fiscal-rule | ||
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
:target: https://translation.odoo-community.org/projects/account-fiscal-rule-14-0/account-fiscal-rule-14-0-account_fiscal_product_rule | ||
:alt: Translate me on Weblate | ||
.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png | ||
:target: https://runbot.odoo-community.org/runbot/251/14.0 | ||
:alt: Try me on Runbot | ||
|
||
|badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
||
This module allows to map tax and account depending of the product. | ||
|
||
**Table of contents** | ||
|
||
.. contents:: | ||
:local: | ||
|
||
Known issues / Roadmap | ||
====================== | ||
|
||
Bug Tracker | ||
=========== | ||
|
||
Bugs are tracked on `GitHub Issues <https://github.com/OCA/account-fiscal-rule/issues>`_. | ||
In case of trouble, please check there if your issue has already been reported. | ||
If you spotted it first, help us smashing it by providing a detailed and welcomed | ||
`feedback <https://github.com/OCA/account-fiscal-rule/issues/new?body=module:%20account_fiscal_product_rule%0Aversion:%2014.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
||
Do not contact contributors directly about support or help with technical issues. | ||
|
||
Credits | ||
======= | ||
|
||
Authors | ||
~~~~~~~ | ||
|
||
* Akretion | ||
|
||
Contributors | ||
~~~~~~~~~~~~ | ||
|
||
* Sébastien Beau <sebastien.beau@akretion.com> | ||
* Chafique Delli <chafique.delli@akretion.com> | ||
|
||
Maintainers | ||
~~~~~~~~~~~ | ||
|
||
This module is maintained by the OCA. | ||
|
||
.. image:: https://odoo-community.org/logo.png | ||
:alt: Odoo Community Association | ||
:target: https://odoo-community.org | ||
|
||
OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
mission is to support the collaborative development of Odoo features and | ||
promote its widespread use. | ||
|
||
This module is part of the `OCA/account-fiscal-rule <https://github.com/OCA/account-fiscal-rule/tree/14.0/account_fiscal_product_rule>`_ project on GitHub. | ||
|
||
You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
from . import models |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Copyright 2022 Akretion | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
{ | ||
"name": "Account Fiscal Product Rule", | ||
"version": "14.0.1.0.0", | ||
"category": "Accounting & Finance", | ||
"author": "Akretion, Odoo Community Association (OCA)", | ||
"website": "https://github.com/OCA/account-fiscal-rule", | ||
"license": "AGPL-3", | ||
"depends": ["account"], | ||
"data": [ | ||
"security/ir.model.access.csv", | ||
"views/product.xml", | ||
"views/account_fiscal_position.xml", | ||
], | ||
"installable": True, | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
from . import account_fiscal_position | ||
from . import product | ||
from . import account_move |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
# Copyright 2022 Akretion France (http://www.akretion.com) | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
||
from odoo import _, api, fields, models | ||
from odoo.exceptions import ValidationError | ||
|
||
|
||
class AccountFiscalPositionProductRule(models.Model): | ||
_name = "account.fiscal.position.product.rule" | ||
_description = "Account Fiscal Position Rule in Product" | ||
|
||
name = fields.Char(required=True) | ||
fiscal_position_id = fields.Many2one("account.fiscal.position", required=True) | ||
product_tmpl_ids = fields.Many2many("product.template") | ||
product_category_ids = fields.Many2many("product.category") | ||
account_income_id = fields.Many2one("account.account") | ||
account_expense_id = fields.Many2one("account.account") | ||
seller_tax_ids = fields.Many2many("account.tax", "account_tax_seller") | ||
supplier_tax_ids = fields.Many2many( | ||
"account.tax", | ||
"account_tax_supplier", | ||
) | ||
company_id = fields.Many2one(related="fiscal_position_id.company_id") | ||
|
||
@api.constrains("product_tmpl_ids") | ||
def _check_no_duplicate_fiscal_position_on_product(self): | ||
self.product_tmpl_ids._check_no_duplicate_fiscal_position() | ||
|
||
@api.constrains("product_category_ids") | ||
def _check_no_duplicate_fiscal_position_on_category(self): | ||
self.product_category_ids._check_no_duplicate_fiscal_position() | ||
|
||
|
||
class ProductRuleMixin(models.AbstractModel): | ||
_name = "product.rule.mixin" | ||
_description = "Product Rule Mixin" | ||
|
||
fiscal_position_product_rule_ids = fields.Many2many( | ||
"account.fiscal.position.product.rule", string="Product Fiscal Rules" | ||
) | ||
|
||
@api.constrains("fiscal_position_product_rule_ids") | ||
def _check_no_duplicate_fiscal_position(self): | ||
for record in self: | ||
fps = [] | ||
for rule in record.fiscal_position_product_rule_ids: | ||
if rule.fiscal_position_id in fps: | ||
raise ValidationError( | ||
_( | ||
"A Fiscal Position Product Rule already exists for this product " | ||
"or product category with this fiscal position !" | ||
) | ||
) | ||
else: | ||
fps.append(rule.fiscal_position_id) | ||
|
||
|
||
class AccountFiscalPosition(models.Model): | ||
_inherit = "account.fiscal.position" | ||
|
||
fiscal_position_product_rule_ids = fields.One2many( | ||
"account.fiscal.position.product.rule", | ||
"fiscal_position_id", | ||
string="Product Fiscal Rules", | ||
) | ||
|
||
def map_tax(self, taxes, product=None, partner=None): | ||
prod = product or self._context.get("product") | ||
if prod: | ||
rule = prod.product_tmpl_id.get_matching_product_fiscal_rule(self) | ||
if rule and taxes: | ||
tax_use = taxes[0].type_tax_use | ||
if tax_use == "sale" and rule.seller_tax_ids: | ||
return rule.seller_tax_ids | ||
elif tax_use == "purchase" and rule.supplier_tax_ids: | ||
return rule.supplier_tax_ids | ||
return super().map_tax(taxes=taxes, product=product, partner=partner) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Copyright 2022 Akretion France (http://www.akretion.com) | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
||
from odoo import api, models | ||
|
||
|
||
class AccountMoveLine(models.Model): | ||
_inherit = "account.move.line" | ||
|
||
@api.onchange("product_id") | ||
def _onchange_product_id(self): | ||
for line in self: | ||
super( | ||
AccountMoveLine, line.with_context(product=line.product_id) | ||
)._onchange_product_id() | ||
|
||
@api.onchange("product_uom_id") | ||
def _onchange_uom_id(self): | ||
for line in self: | ||
super( | ||
AccountMoveLine, line.with_context(product=line.product_id) | ||
)._onchange_uom_id() |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
# Copyright 2022 Akretion France (http://www.akretion.com) | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
||
from odoo import models | ||
|
||
|
||
class ProductCategory(models.Model): | ||
_name = "product.category" | ||
_inherit = ["product.category", "product.rule.mixin"] | ||
|
||
def get_matching_product_fiscal_rule(self, fiscal_pos): | ||
self.ensure_one() | ||
return self.fiscal_position_product_rule_ids.filtered( | ||
lambda r: r.fiscal_position_id == fiscal_pos | ||
) or ( | ||
self.parent_id | ||
and self.parent_id.get_matching_product_fiscal_rule(fiscal_pos) | ||
) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should add a python constraint to be sure to not put 2 account.fiscal.position.rule related to the same fiscal position something like
To avoid duplicated code for this constraint. You can create a mixin (fiscal.position.product.rule.owner) and put the code for the field definition "fiscal_position_product_rule_ids" and the constrainte There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
class ProductTemplate(models.Model): | ||
_name = "product.template" | ||
_inherit = ["product.template", "product.rule.mixin"] | ||
|
||
def get_matching_product_fiscal_rule(self, fiscal_pos): | ||
self.ensure_one() | ||
return self.fiscal_position_product_rule_ids.filtered( | ||
lambda r: r.fiscal_position_id == fiscal_pos | ||
) or self.categ_id.get_matching_product_fiscal_rule(fiscal_pos) | ||
|
||
def get_product_accounts(self, fiscal_pos=None): | ||
if fiscal_pos: | ||
rule = self.get_matching_product_fiscal_rule(fiscal_pos) | ||
if rule: | ||
return { | ||
"income": rule.account_income_id, | ||
"expense": rule.account_expense_id, | ||
} | ||
return super().get_product_accounts(fiscal_pos=fiscal_pos) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
* Sébastien Beau <sebastien.beau@akretion.com> | ||
* Chafique Delli <chafique.delli@akretion.com> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
This module allows to map tax and account depending of the product. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | ||
access_account_fiscal_position_product_rule,access on account.fiscal.position.product.rule,model_account_fiscal_position_product_rule,account.group_account_user,1,1,1,1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the rule is not dependent anymore from the (product) source tax, what about price included or not?
I think you need to ensure the new tax has the same
price_include
state