[16.0][IMP] account_product_fiscal_classification: add sequence #379
Conversation
|
Hi @legalsylvain, |
| @@ -8,6 +8,7 @@ | |||
| class AccountProductFiscalClassificationTemplate(models.Model): | |||
| _name = "account.product.fiscal.classification.template" | |||
| _description = "Fiscal Classification Template" | |||
| _order = "sequence, id" | |||
There was a problem hiding this comment.
| _order = "sequence, id" | |
| _order = "sequence, name" |
if two items have the same sequence. (that occures, when updating this module), better to order by name.
There was a problem hiding this comment.
In the current implementation, there is no "_order", so it is order by id. So "sequence, id" keeps the current order on existing installations.
There was a problem hiding this comment.
indeed, but is it what we want ?
There was a problem hiding this comment.
yes ! That way, we don't change the habits of the users until they decide the exact order they want.
There was a problem hiding this comment.
I mean, order by id is wrong, and has been fixed by #275 monthes ago.
But this patch has not been back-ported.
I think it should.
the order by sequence is OK, but please take the opportunity to backport this trivial patch !
thanks !
| @@ -9,6 +9,7 @@ | |||
| class AccountProductFiscalClassification(models.Model): | |||
| _name = "account.product.fiscal.classification" | |||
| _description = "Fiscal Classification" | |||
| _order = "sequence, id" | |||
There was a problem hiding this comment.
| _order = "sequence, id" | |
| _order = "sequence, name" |
same here.
account_product_fiscal_classification/models/account_product_fiscal_classification.py
Outdated
Show resolved
Hide resolved
alexis-via
force-pushed
the
16-account_product_fiscal_classification-sequence
branch
from
c790c89 to
836e383
Compare
|
On the form view of account.product.fiscal.classification, we have a "notebook" with a single "page"... why ? There are other modules which add tabs to this form view ? |
? |
|
comment updated. Github dislikes when you write XML tags directly in the text of the comment! |
|
Ready to merge ! |
|
@legalsylvain Can you approve please, so we follow due process? |
|
Hi !
Generally, I add a notebook on form view. It allows to add extra tab in custom / OCA modules.
No, my comment (#379 (comment)) is not answered. But no problem : I backported #275 here (#388), so this PR has just to be rebase, and could be merged. |
alexis-via
force-pushed
the
16-account_product_fiscal_classification-sequence
branch
from
836e383 to
cf933f7
Compare
|
rebased |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
No description provided.