[15.0] dotfiles update needs manual intervention #383
Conversation
dreispt
force-pushed
the
15.0-ocabot-update-dotfiles
branch
from
0c4df43 to
b425805
Compare
| @@ -4,7 +4,7 @@ | |||
| @author Sylvain LE GAL (https://twitter.com/legalsylvain) | |||
| License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | |||
| --> | |||
| <!-- pylint: disable=duplicate-xml-record-id --> | |||
| <!-- oca-hooks:disable=duplicate-xml-record-id --> | |||
There was a problem hiding this comment.
@etobella @moylop260 @sbidoul Pre-commit fails with duplicate-xml-record-id, even though it is being disable. What's missing?
There was a problem hiding this comment.
The check name is different.
There was a problem hiding this comment.
Thank you @pedrobaeza , I corrected it, but it still fails. I may be missing something.
dreispt
force-pushed
the
15.0-ocabot-update-dotfiles
branch
2 times, most recently
from
975f471 to
bea6fb5
Compare
dreispt
force-pushed
the
15.0-ocabot-update-dotfiles
branch
from
bea6fb5 to
dc9494e
Compare
.pre-commit-config.yaml
Outdated
| @@ -125,7 +142,7 @@ repos: | |||
| name: flake8 | |||
| additional_dependencies: ["flake8-bugbear==21.9.2"] | |||
| - repo: https://github.com/OCA/pylint-odoo | |||
| rev: 7.0.2 | |||
| rev: 7.0.5 | |||
There was a problem hiding this comment.
The repo https://github.com/OCA/odoo-pre-commit-hooks born with pylint-odoo checks migrated to hooks
But it was done after pylint_odoo >= 8.0
So, if you add odoo-pre-commit-hooks you will need to update pylint-odoo to >=8.0 to avoid duplicating checks
I meant, pylint-odoo < 8.0 is not compatible with odoo-pre-commit-hooks
dreispt
force-pushed
the
15.0-ocabot-update-dotfiles
branch
from
dc9494e to
4c79073
Compare
|
/ocabor merge nobump |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 4a217b8. Thanks a lot for contributing to OCA. ❤️ |
Dear maintainer,
After updating the dotfiles,
pre-commit run -afails in a manner that cannot be resolved automatically.
Can you please have a look, fix and merge?
Thanks,