[FIX] account_fiscal_position_type: prevent error in demo / test mode, if l10n_generic_coa is not installed #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, if l10n_generic_coa is not installed
legalsylvain
force-pushed
the
12.0-FIX-account_fiscal_position_type-prevent-error-l10n_generic_coa
branch
from
2fb8eb1 to
7ef0eaa
Compare
rvalyi
approved these changes
Nov 6, 2024
|
/ocabot merge patch |
|
Sorry @legalsylvain you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
@rvalyi : could you merge ? |
dreispt
approved these changes
Nov 30, 2024
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 73c83d7. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rational
demo and test are based on l10n_generic_coa data. However, if other localization are installed, the installation of this module will fail with demo data.
Action
create a dedicated demo chart of account.
similar to v16 implementation.
https://github.com/OCA/account-fiscal-rule/blob/16.0/account_fiscal_position_type/demo/account_chart_template.xml