Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] account_avatax_oca: Migration to 18.0 #466

Merged
merged 49 commits into from
Jan 8, 2025
Merged

[18.0][MIG] account_avatax_oca: Migration to 18.0 #466

merged 49 commits into from
Jan 8, 2025

Conversation

kobros-tech
Copy link

No description provided.

dreispt and others added 30 commits December 5, 2024 18:45
@dreispt @kobros-tech
account_avatax_oca: renamed from account_avatax
9bcd076
@dreispt @kobros-tech
account_avatax_oca: fix README title levels
c6a4fd2
@kobros-tech
Update account_avatax_oca.pot
8b20c7c
@OCA-git-bot @kobros-tech
README.rst
d1c97df
@OCA-git-bot @kobros-tech
account_avatax_oca 15.0.2.0.0
a13d172
@atchuthan @kobros-tech
account_avatax: Override line taxes at Invoice
a735628
@OCA-git-bot @kobros-tech
account_avatax_oca 15.0.2.0.1
c0c85a2
@Nikul-OSI @kobros-tech
account_avatax_oca: Migrated to v16
83fa4e9
@kobros-tech
Update account_avatax_oca.pot
e391e20
@OCA-git-bot @kobros-tech
README.rst
9f0d75d
@OCA-git-bot @kobros-tech
README.rst
4ea14c7
@RLeeOSI @kobros-tech
account_avatax_oca: tax calculation improvements
7ddd7bc 
* [FIX] compound rate computation adjustment

* [FIX] model inconsistencies in migration

* [FIX] replace _recompute_dynamic_lines with _sync_dynamic_lines

* [FIX] unbalanced entries error
@OCA-git-bot @kobros-tech
post-merge updates
92be2f1
@dreispt @kobros-tech
account_avatax_oca: fix unbalanced error on save
bed7a12
@OCA-git-bot @kobros-tech
post-merge updates
61758a5
@metaminux @kobros-tech
account_avatax_oca : override the create method in batch
2999c9c
@OCA-git-bot @kobros-tech
post-merge updates
ea66fb7
@metaminux @kobros-tech
account_avatax_oca : use original parameters when calling super metho…
de9fcb7 
…d in compute_all
@OCA-git-bot @kobros-tech
post-merge updates
37ba182
@metaminux @kobros-tech
account_avatax_oca : actually trigger avatax calculation on save when…
3089443 
… invoice lines have changed
@metaminux @kobros-tech
account_avatax_oca : remove obsolete method "_get_price_total_and_sub…
f715b9f 
…total"
@OCA-git-bot @kobros-tech
post-merge updates
7e8c191
@OCA-git-bot @kobros-tech
post-merge updates
d858a66
@kobros-tech
account_avatax_oca: don't overwrite date on refund
9225f66
@OCA-git-bot @kobros-tech
post-merge updates
811a261
@kobros-tech
account_avatax_oca: add search criteria to avoid singleton
8ec9204
@OCA-git-bot @kobros-tech
post-merge updates
f974604
@mymage @kobros-tech
Added translation using Weblate (Italian)
e5df4fc
@Nikul-OSI @kobros-tech
[FIX] account_avatax_oca: black, isort, prettier
2094668
@Nikul-OSI @kobros-tech
[MIG] account_avatax_oca: Migrated to v17
8864ae8
OCA-git-bot and others added 12 commits December 5, 2024 18:45
@OCA-git-bot @kobros-tech
[BOT] post-merge updates
149ae10
@mymage @kobros-tech
Translated using Weblate (Italian)
e471f9f 
Currently translated at 37.5% (71 of 189 strings)

Translation: account-fiscal-rule-17.0/account-fiscal-rule-17.0-account_avatax_oca
Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-17-0/account-fiscal-rule-17-0-account_avatax_oca/it/
@mymage @kobros-tech
Translated using Weblate (Italian)
8dd61bb 
Currently translated at 100.0% (189 of 189 strings)

Translation: account-fiscal-rule-17.0/account-fiscal-rule-17.0-account_avatax_oca
Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-17-0/account-fiscal-rule-17-0-account_avatax_oca/it/
@dreispt @kobros-tech
[FIX] account_avatax_oca: Exemption is editable for Accounting Manage…
8f8294a 
…r group
@OCA-git-bot @kobros-tech
[BOT] post-merge updates
26bdaa2
@mymage @kobros-tech
Translated using Weblate (Italian)
2235794 
Currently translated at 100.0% (189 of 189 strings)

Translation: account-fiscal-rule-17.0/account-fiscal-rule-17.0-account_avatax_oca
Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-17-0/account-fiscal-rule-17-0-account_avatax_oca/it/
@tirth-osi @kobros-tech
[FIX] Allowing Internal Users to Validate the Contact Address
87c9f0e
@OCA-git-bot @kobros-tech
[BOT] post-merge updates
983736b
@mymage @kobros-tech
Translated using Weblate (Italian)
87d68fa 
Currently translated at 100.0% (189 of 189 strings)

Translation: account-fiscal-rule-17.0/account-fiscal-rule-17.0-account_avatax_oca
Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-17-0/account-fiscal-rule-17-0-account_avatax_oca/it/
@pedrobaeza @kobros-tech
[FIX] account_avatax_oca: Pre-commit fixes
e8fc483
@OCA-git-bot @kobros-tech
[BOT] post-merge updates
8a709f2
@mymage @kobros-tech
Translated using Weblate (Italian)
b66d2ce 
Currently translated at 100.0% (189 of 189 strings)

Translation: account-fiscal-rule-17.0/account-fiscal-rule-17.0-account_avatax_oca
Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-17-0/account-fiscal-rule-17-0-account_avatax_oca/it/
@kobros-tech kobros-tech mentioned this pull request Jan 7, 2025
Closed
@kobros-tech
Copy link
Author

from PR #459

@kobros-tech
Copy link
Author

@dnplkndll

@kobros-tech kobros-tech force-pushed the 18.0-mig-account_avatax_oca branch from 033bbf1 to f0f84fe Compare January 7, 2025 19:06
dreispt
dreispt approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, especially the API mock tests, thank you.

For the record, I believe the tax overriding technique could be simpler than the original implementation, but that's an idea for future improvements.

Please say hi to Don on my behalf.

wlin-kencove
wlin-kencove approved these changes Jan 8, 2025
View reviewed changes
Copy link

@wlin-kencove wlin-kencove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and I can confirm from local testing that taxes are calculated using a live avalara connection on Account Move.

@dreispt
Copy link
Member

dreispt commented Jan 8, 2025

/ocabot migration account_avatax_oca
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 8, 2025
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-466-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jan 8, 2025
Open
6 tasks
@OCA-git-bot OCA-git-bot merged commit 5f83e36 into OCA:18.0 Jan 8, 2025
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a56b20e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlin-kencove wlin-kencove wlin-kencove approved these changes

@dnplkndll dnplkndll dnplkndll approved these changes

@dreispt dreispt dreispt approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.