[16.0][FIX] account_statement_import_online_gocardless : Correction o…

…f the endpoint token/refresh request datas, plus the behavior of the _gocardless_get_token method which in case of a non expired refresh token was calling the endpoint token/new instead of token/refresh
OCA · Jan 7, 2025 · 271ae91 · 271ae91
1 parent 2298d49
commit 271ae91
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/account_statement_import_online_gocardless/README.rst b/account_statement_import_online_gocardless/README.rst
@@ -129,6 +129,9 @@ Contributors
 * `Alusage <https://nicolas.alusage.fr>`__:
 
   * Nicolas JEUDY <https://github.com/njeudy>
+* `ArPol <https://arpol.fr>`__:
+
+  * Armand POLMARD <https://github.com/arpol-dev>
 
 Maintainers
 ~~~~~~~~~~~

diff --git a/account_statement_import_online_gocardless/models/online_bank_statement_provider.py b/account_statement_import_online_gocardless/models/online_bank_statement_provider.py
@@ -84,17 +84,17 @@ def _gocardless_get_token(self):
             # Refresh token
             if (
                 self.gocardless_refresh_token
-                and now > self.gocardless_refresh_expiration
+                and now < self.gocardless_refresh_expiration
             ):
                 endpoint = "token/refresh"
+                request_data = {"refresh": self.gocardless_refresh_token}
             else:
                 endpoint = "token/new"
+                request_data = {"secret_id": self.username, "secret_key": self.password}
             _response, data = self._gocardless_request(
                 endpoint,
                 request_type="post",
-                data=json.dumps(
-                    {"secret_id": self.username, "secret_key": self.password}
-                ),
+                data=json.dumps(request_data),
                 basic_auth=True,
             )
             expiration_date = now + relativedelta(seconds=data.get("access_expires", 0))

diff --git a/account_statement_import_online_gocardless/readme/CONTRIBUTORS.rst b/account_statement_import_online_gocardless/readme/CONTRIBUTORS.rst
@@ -8,3 +8,6 @@
 * `Alusage <https://nicolas.alusage.fr>`__:
 
   * Nicolas JEUDY <https://github.com/njeudy>
+* `ArPol <https://arpol.fr>`__:
+
+  * Armand POLMARD <https://github.com/arpol-dev>
diff --git a/account_statement_import_online_gocardless/static/description/index.html b/account_statement_import_online_gocardless/static/description/index.html
@@ -494,6 +494,10 @@ <h2><a class="toc-backref" href="#toc-entry-8">Contributors</a></h2>
 <li>Nicolas JEUDY &lt;<a class="reference external" href="https://github.com/njeudy">https://github.com/njeudy</a>&gt;</li>
 </ul>
 </li>
+<li><a class="reference external" href="https://arpol.fr">ArPol</a>:<ul>
+<li>Armand POLMARD &lt;<a class="reference external" href="https://github.com/arpol-dev">https://github.com/arpol-dev</a>&gt;</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">