-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][imp] - sanitized bank account number instead of account number #593
Conversation
@alexis-via could you check/validate this one please |
Hi @alexis-via, |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@alexis-via did you have the time to check this? not sure why runboat/build is pending or how to start it... |
You could rebase and (force) push to create a runboat. |
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/es/
Currently translated at 100.0% (7 of 7 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_ofx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_ofx/es/
Currently translated at 100.0% (5 of 5 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/hr/
Currently translated at 100.0% (5 of 5 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/es/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/fr/
Currently translated at 100.0% (4 of 4 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_ofx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_ofx/fr/
Currently translated at 100.0% (5 of 5 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/
Currently translated at 58.3% (21 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/pt_BR/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_ofx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_ofx/pt_BR/
Currently translated at 100.0% (5 of 5 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/pt_BR/
Currently translated at 100.0% (87 of 87 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_txt_xlsx/es_AR/ account_statement_import_txt_xlsx 14.0.1.0.1
[UPD] Update account_statement_import_txt_xlsx.pot [UPD] README.rst
Currently translated at 100.0% (87 of 87 strings) Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/it/
…r IN and OUT [IMP] account_statement_import_txt_xlsx: wizard: amount2_reverse boolean field, with tests
… to column numbers, and concatenation A new field 'File does not contain header line' is added in the Statement Sheet Mappings. If you set to True, then you can map the columns by indicating in each field of the 'Columns' section the column number in the file. We also allow to concatenate multiple columns in the file to a single column to a single field of the statement line. You have to indicate the names of the columns separated by comma.
…ot provided in the import file [UPD] Update account_statement_import_txt_xlsx.pot account_statement_import_txt_xlsx 15.0.2.0.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/
…ping account_statement_import_txt_xlsx 15.0.2.0.1
If there is a problem parsing the file we are not showing the error to the user, instead a generic message telling something is wrong with the type of file is shown, and we only showing the error if we are running unit tests. In this case we think is good to show the error to the user, this way they can check what is wrong and fix it in the sheet mapping. * We are only showing the title of the error as a HINT, we think that is a good start to undestand what needs to change in the sheet mapping. * The complete traceback error is shown in the log if we needed for more detail review from the technical teams.
Currently translated at 74.4% (73 of 98 strings) Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/it/
Currently translated at 98.9% (97 of 98 strings) Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/es/
- Depending on the installed set of modules, the company currency may be USD or EUR. If the second case, these tests will fail, so we make sure that the company currency is USD for our tests, doing the change by SQL, as there's a Python constraint that prevents it. Not needed in v17 due to: odoo/odoo#107113. account_statement_import_txt_xlsx 15.0.2.0.2 [UPD] Update account_statement_import_txt_xlsx.pot account_statement_import_txt_xlsx 15.0.2.0.3 [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/
Co-authored-by: zaoral
[IMP] add csv meta data management [FIX] exclude footer meta data [IMP] import separated credit/debit column file [FIX] make comptatible with new version of multi_step_wizard module & add migration file [FIX] all not provided value are handled in_parse_decimal method [REF] Remove unnecessary \n Renamed to account_statement_import_sheet_file Co-authored-by: zaoral
Currently translated at 100.0% (95 of 95 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_sheet_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_sheet_file/es/
Currently translated at 100.0% (154 of 154 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online_paypal Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online_paypal/es/
Currently translated at 100.0% (90 of 90 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online/es/
Currently translated at 100.0% (24 of 24 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online_ponto Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online_ponto/es/
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Use sanitized_acc_number instead of acc_number - so the wizard from module import_bank_statement_file gets correct values for comparison, as it is also using sinitized_acc_number