-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][ADD] account_bank_statement_import_file_hook #595
[13.0][ADD] account_bank_statement_import_file_hook #595
Conversation
f1c4327
to
42bc964
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LVGTM!
/ocabot merge nobump |
On my way to merge this fine PR! |
@AaronHForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-595-by-AaronHForgeFlow-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, aborting. Why do you need to do such hooks? This is a very bad practice. What do you want to get?
@pedrobaeza, Odoo does the processing of the file in such a way that you are not able to tap into the logic, to modify it while having access to the ir.attachment record being processed. None of the functions called inside the for loop in the import_file() function are passed the attachment as a record. Having this hook might be interesting in cases such as the one we are working with, where we want to link the resulting statement with the attachment. |
I think you can override |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Hi, just reopening this |
sorry wrong PR |
No description provided.