[16.0][MIG] account_statement_import_txt_xlsx > account_statement_import_sheet_file: Migration to 16.0 #628

victoralmau · 2023-09-26T08:18:16Z

Superseed #559

Migration to 16.0

@Tecnativa TT45222

chienandalu

Tested. Just a tiny glitch with this block not taking enough space:

pedrobaeza · 2023-09-27T10:10:05Z

/ocabot migration account_statement_import_txt_xlsx

pedrobaeza · 2023-09-27T10:10:46Z

I see up to 5 commits of Italian translation from the same contributor that can be squashed.

chienandalu

Thanks :)

OCA-git-bot · 2023-10-11T07:26:35Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bhaveshselarka · 2023-10-12T04:42:09Z

@victoralmau Any idea when it will be merge into 16.0 ?

pedrobaeza

The module should be renamed to account_statement_import_csv_txt_xls (or maybe better account_statement_import_sheet_file).

account_statement_import_txt_xlsx/models/account_statement_import_sheet_mapping.py

account_statement_import_txt_xlsx/readme/CONTRIBUTORS.rst

account_statement_import_txt_xlsx/wizards/account_statement_import_sheet_mapping_wizard.xml

victoralmau · 2023-10-17T14:07:10Z

Changes done and renamed to account_statement_import_sheet_file

pedrobaeza

POT/PO files are not touched

account_statement_import_sheet_file/models/account_statement_import_sheet_mapping.py

account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py

…r IN and OUT [IMP] account_statement_import_txt_xlsx: wizard: amount2_reverse boolean field, with tests

…credit_column

… to column numbers, and concatenation A new field 'File does not contain header line' is added in the Statement Sheet Mappings. If you set to True, then you can map the columns by indicating in each field of the 'Columns' section the column number in the file. We also allow to concatenate multiple columns in the file to a single column to a single field of the statement line. You have to indicate the names of the columns separated by comma.

…ot provided in the import file [UPD] Update account_statement_import_txt_xlsx.pot account_statement_import_txt_xlsx 15.0.2.0.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/

…ping account_statement_import_txt_xlsx 15.0.2.0.1

If there is a problem parsing the file we are not showing the error to the user, instead a generic message telling something is wrong with the type of file is shown, and we only showing the error if we are running unit tests. In this case we think is good to show the error to the user, this way they can check what is wrong and fix it in the sheet mapping. * We are only showing the title of the error as a HINT, we think that is a good start to undestand what needs to change in the sheet mapping. * The complete traceback error is shown in the log if we needed for more detail review from the technical teams.

Currently translated at 74.4% (73 of 98 strings) Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/it/

Currently translated at 98.9% (97 of 98 strings) Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/es/

- Depending on the installed set of modules, the company currency may be USD or EUR. If the second case, these tests will fail, so we make sure that the company currency is USD for our tests, doing the change by SQL, as there's a Python constraint that prevents it. Not needed in v17 due to: odoo/odoo#107113. account_statement_import_txt_xlsx 15.0.2.0.2 [UPD] Update account_statement_import_txt_xlsx.pot account_statement_import_txt_xlsx 15.0.2.0.3 [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/

Co-authored-by: zaoral

account_statement_import_sheet_file/migrations/16.0.1.0.0/pre-migration.py

[IMP] add csv meta data management [FIX] exclude footer meta data [IMP] import separated credit/debit column file [FIX] make comptatible with new version of multi_step_wizard module & add migration file [FIX] all not provided value are handled in_parse_decimal method [REF] Remove unnecessary \n Renamed to account_statement_import_sheet_file Co-authored-by: zaoral

heroic · 2023-10-26T17:23:06Z

Any chance this gets merged soon? We've been stuck without file imports for a long time. Happy to help in whatever way needed to get this merged.

pedrobaeza · 2023-10-26T17:24:49Z

You can review it and test if everything is correct. I'll check soon for removing my requested changes.

cathLemb · 2023-10-31T16:25:27Z

I've tested it and it seems to work fine from a functionnal point of view

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2023-10-31T19:25:49Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-628-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-10-31T19:33:04Z

Congratulations, your PR was merged at 9871483. Thanks a lot for contributing to OCA. ❤️

Signed-off-by pedrobaeza

victoralmau mentioned this pull request Sep 26, 2023

[MIG] account_statement_import_txt_xlsx: Migration to 16.0 #559

Closed

MiquelRForgeFlow approved these changes Sep 26, 2023

View reviewed changes

victoralmau force-pushed the 16.0-mig-account_statement_import_txt_xlsx branch from 1ab0e08 to 715a400 Compare September 26, 2023 08:59

chienandalu reviewed Sep 27, 2023

View reviewed changes

victoralmau force-pushed the 16.0-mig-account_statement_import_txt_xlsx branch 2 times, most recently from 98405b7 to e1d7e68 Compare September 27, 2023 10:09

OCA-git-bot added this to the 16.0 milestone Sep 27, 2023

OCA-git-bot mentioned this pull request Sep 27, 2023

Migration to version 16.0 #503

Open

13 tasks

victoralmau force-pushed the 16.0-mig-account_statement_import_txt_xlsx branch from e1d7e68 to c01f6ad Compare September 27, 2023 10:12

chienandalu approved these changes Sep 27, 2023

View reviewed changes

OCA-git-bot added the approved label Sep 27, 2023

OCA-git-bot added the ready to merge label Oct 11, 2023

pedrobaeza force-pushed the 16.0-mig-account_statement_import_txt_xlsx branch from c01f6ad to b0c14ee Compare October 12, 2023 09:46

pedrobaeza requested changes Oct 12, 2023

View reviewed changes

OCA-git-bot removed approved ready to merge labels Oct 12, 2023

victoralmau force-pushed the 16.0-mig-account_statement_import_txt_xlsx branch 2 times, most recently from b684ebb to 9893eb2 Compare October 17, 2023 13:55

victoralmau changed the title ~~[16.0][MIG] account_statement_import_txt_xlsx: Migration to 16.0~~ [16.0][MIG] account_statement_import_txt_xlsx > account_statement_import_sheet_file: Migration to 16.0 Oct 17, 2023

victoralmau force-pushed the 16.0-mig-account_statement_import_txt_xlsx branch 2 times, most recently from 5668de7 to 4254196 Compare October 17, 2023 14:04

pedrobaeza reviewed Oct 17, 2023

View reviewed changes

victoralmau force-pushed the 16.0-mig-account_statement_import_txt_xlsx branch from 4254196 to 7ecaefd Compare October 18, 2023 06:58

NuriaMForgeFlow and others added 13 commits October 19, 2023 08:21

[FIX] account_bank_statement_import_txt_xlsx: import sheet notes

e648704

[IMP] account_statement_import_txt_xlsx: wizard: 2 amount columns, fo…

111f2dd

…r IN and OUT [IMP] account_statement_import_txt_xlsx: wizard: amount2_reverse boolean field, with tests

[IMP] account_statement_import_txt_xlsx: amount_debit_column, amount_…

5144f95

…credit_column

[IMP] account_statement_import_txt_xlsx: add tests

361967b

[FIX] account_statement_import_txt_xlsx: Don't try to parse if no map…

e7039c0

…ping account_statement_import_txt_xlsx 15.0.2.0.1

Added translation using Weblate (Spanish)

3c35579

[MIG] account_statement_import_txt_xlsx: Migration to 16.0

d06179c

Co-authored-by: zaoral

victoralmau force-pushed the 16.0-mig-account_statement_import_txt_xlsx branch from cf2e16a to 3c09120 Compare October 19, 2023 06:44

pedrobaeza reviewed Oct 19, 2023

View reviewed changes

account_statement_import_sheet_file/migrations/16.0.1.0.0/pre-migration.py Show resolved Hide resolved

victoralmau force-pushed the 16.0-mig-account_statement_import_txt_xlsx branch from 3c09120 to 13285ab Compare October 19, 2023 08:43

pedrobaeza approved these changes Oct 31, 2023

View reviewed changes

OCA-git-bot added the approved label Oct 31, 2023

OCA-git-bot added the bot is merging ⏳ label Oct 31, 2023

OCA-git-bot merged commit 86c170d into OCA:16.0 Oct 31, 2023
4 of 6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 31, 2023

pedrobaeza deleted the 16.0-mig-account_statement_import_txt_xlsx branch October 31, 2023 19:33

victoralmau pushed a commit to Tecnativa/bank-statement-import that referenced this pull request Apr 4, 2024

Merge PR OCA#628 into 16.0

b461d47

Signed-off-by pedrobaeza

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] account_statement_import_txt_xlsx > account_statement_import_sheet_file: Migration to 16.0 #628

[16.0][MIG] account_statement_import_txt_xlsx > account_statement_import_sheet_file: Migration to 16.0 #628

victoralmau commented Sep 26, 2023

chienandalu left a comment

pedrobaeza commented Sep 27, 2023

pedrobaeza commented Sep 27, 2023

chienandalu left a comment

OCA-git-bot commented Oct 11, 2023

bhaveshselarka commented Oct 12, 2023

pedrobaeza left a comment

victoralmau commented Oct 17, 2023

pedrobaeza left a comment

heroic commented Oct 26, 2023

pedrobaeza commented Oct 26, 2023

cathLemb commented Oct 31, 2023

pedrobaeza left a comment

OCA-git-bot commented Oct 31, 2023

OCA-git-bot commented Oct 31, 2023

[16.0][MIG] account_statement_import_txt_xlsx > account_statement_import_sheet_file: Migration to 16.0 #628

[16.0][MIG] account_statement_import_txt_xlsx > account_statement_import_sheet_file: Migration to 16.0 #628

Conversation

victoralmau commented Sep 26, 2023

chienandalu left a comment

Choose a reason for hiding this comment

pedrobaeza commented Sep 27, 2023

pedrobaeza commented Sep 27, 2023

chienandalu left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Oct 11, 2023

bhaveshselarka commented Oct 12, 2023

pedrobaeza left a comment

Choose a reason for hiding this comment

victoralmau commented Oct 17, 2023

pedrobaeza left a comment

Choose a reason for hiding this comment

heroic commented Oct 26, 2023

pedrobaeza commented Oct 26, 2023

cathLemb commented Oct 31, 2023

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Oct 31, 2023

OCA-git-bot commented Oct 31, 2023