-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] account_statement_import_online_paypal: Migration to version 16.0 #630
[16.0][MIG] account_statement_import_online_paypal: Migration to version 16.0 #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review OK
CI is red |
@stefan-tecnativa You might want to rebase this one now 548 is merged. |
…_statement_import_online_paypal
8537046
to
ee75acc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
/ocabot migration account_statement_import_online_paypal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash administrative commits https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests
ee75acc
to
64801aa
Compare
The 2 modules account_statement_import_online and account_statement_import depend on account_statement_import_base (and not on each other) and share common code, in particular a hook to update the statement line. So we can now have reconciliation modules that use this hook and therefore work both on file import and online import. More details on OCA#481. Improve bank statement line form view and journal form view.
…, and ROADMAP to current Odoo & PayPal menus/procedures/links. (1) Odoo's menu has changed over the recent versions, and these changes help new users to better understand how to create a PayPal-related Bank Account/Journal and configuration for syncing with PayPal's servers. (2) The order of CONFIGURE was changed to the logical flow of obtaining PayPal credentials first and then configuring Odoo to match. (3) PayPal's URL for transaction definitions has changed and was updated in ROADMAP.
…low Empty Statements" provider setting Empty statements should only be created if "Allow Empty Statements" is checked. This commit adds a check for the state of the allow_empty_statements field.
64801aa
to
5e7ff97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at db01878. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT45361
@victoralmau @NL66278 please review!
This PR depends on: #548