Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_statement_import_online_paypal: Migration to version 16.0 #630

Merged

Conversation

stefan-tecnativa
Copy link
Contributor

cc @Tecnativa TT45361

@victoralmau @NL66278 please review!

This PR depends on: #548

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK

@pedrobaeza
Copy link
Member

CI is red

@NL66278
Copy link
Contributor

NL66278 commented Oct 18, 2023

@stefan-tecnativa You might want to rebase this one now 548 is merged.

@stefan-tecnativa stefan-tecnativa force-pushed the 16.0-mig-account_statement_import_online_paypal branch from 8537046 to ee75acc Compare October 18, 2023 09:20
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@pedrobaeza
Copy link
Member

/ocabot migration account_statement_import_online_paypal

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 18, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 18, 2023
13 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

account_statement_import_online_paypal/__manifest__.py Outdated Show resolved Hide resolved
@stefan-tecnativa stefan-tecnativa force-pushed the 16.0-mig-account_statement_import_online_paypal branch from ee75acc to 64801aa Compare October 19, 2023 06:03
omar7r and others added 8 commits October 19, 2023 08:04
The 2 modules account_statement_import_online and
account_statement_import depend on account_statement_import_base (and
not on each other) and share common code, in particular a hook to update
the statement line. So we can now have reconciliation modules that use
this hook and therefore work both on file import and online import. More
details on OCA#481.

Improve bank statement line form view and journal form view.
…, and ROADMAP to current Odoo & PayPal menus/procedures/links.

(1) Odoo's menu has changed over the recent versions, and these changes help new users to better understand how to create a PayPal-related Bank Account/Journal and configuration for syncing with PayPal's servers.
(2) The order of CONFIGURE was changed to the logical flow of obtaining PayPal credentials first and then configuring Odoo to match.
(3) PayPal's URL for transaction definitions has changed and was updated in ROADMAP.
…low Empty Statements" provider setting

Empty statements should only be created if "Allow Empty Statements" is checked. This commit adds a check for the state of the allow_empty_statements field.
@stefan-tecnativa stefan-tecnativa force-pushed the 16.0-mig-account_statement_import_online_paypal branch from 64801aa to 5e7ff97 Compare October 19, 2023 06:04
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-630-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a581561 into OCA:16.0 Oct 19, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at db01878. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-account_statement_import_online_paypal branch October 19, 2023 08:57
victoralmau pushed a commit to Tecnativa/bank-statement-import that referenced this pull request Apr 4, 2024
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants