Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_statement_import_online: Change pull button visibility #638

Conversation

pedrobaeza
Copy link
Member

Forward-port of #637

You may have an old value on online_bank_statement_provider, but switched to another source, and thus, the button is still visible, which is not correct.

Let's use the source selection as the invisible modifier.

@Tecnativa

You may have an old value on online_bank_statement_provider, but
switched to another source, and thus, the button is still visible,
which is not correct.

Let's use the source selection as the invisible modifier.
@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 15, 2023
@OCA-git-bot
Copy link
Contributor

Hi @alexey-pelykh,
some modules you are maintaining are being modified, check this out!

****po-python-parse-format****
account_statement_import_online/i18n/es.po:136 Translation string couldn't be parsed correctly using str.format KeyError('excepction') - [po-python-parse-format]
@pedrobaeza
Copy link
Member Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-638-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 38d6a16 into OCA:16.0 Nov 15, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9d27918. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-fix-account_statement_import_online-button_visibility branch November 15, 2023 08:00
victoralmau pushed a commit to Tecnativa/bank-statement-import that referenced this pull request Apr 4, 2024
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants