Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] account_statement_import_online_paypal: new paypal event_codes #644

Conversation

ntsirintanis
Copy link
Contributor

Related: #642

@OCA-git-bot
Copy link
Contributor

Hi @alexey-pelykh,
some modules you are maintaining are being modified, check this out!

@ntsirintanis ntsirintanis changed the title [UPD] account_statement_import_online_paypal: new paypal event_code [15.0][UPD] account_statement_import_online_paypal: new paypal event_code Dec 14, 2023
@alexey-pelykh
Copy link
Contributor

@ntsirintanis Thanks for the PR! Is there a chance you'd be willing to port that across the versions? Also, is there a T0402 message?

@ntsirintanis
Copy link
Contributor Author

@ntsirintanis Thanks for the PR! Is there a chance you'd be willing to port that across the versions? Also, is there a T0402 message?

Hoi Alexey, yes, there actually is:

Transfer Withdrawal T0402 Withdrawal to Hyperwallet DR

Though I am not quite sure if this is relevant to Odoo. Nevertheless, I can add another key.

@alexey-pelykh
Copy link
Contributor

@ntsirintanis if that's not too troublesome, please add - there are a lot of keys that are probably irrelevant yet they are there. I'll fast-track the changes anyways

@pedrobaeza
Copy link
Member

[UPD] > [IMP]

@ntsirintanis ntsirintanis force-pushed the 15.0-account_statement_import_online_paypal_update_event_code branch from b27ebaf to 9c493e7 Compare December 15, 2023 09:02
@ntsirintanis ntsirintanis changed the title [15.0][UPD] account_statement_import_online_paypal: new paypal event_code [15.0][UPD] account_statement_import_online_paypal: new paypal event_codes Dec 15, 2023
@ntsirintanis ntsirintanis changed the title [15.0][UPD] account_statement_import_online_paypal: new paypal event_codes [15.0][IMP] account_statement_import_online_paypal: new paypal event_codes Dec 15, 2023
@ntsirintanis
Copy link
Contributor Author

@ntsirintanis if that's not too troublesome, please add - there are a lot of keys that are probably irrelevant yet they are there. I'll fast-track the changes anyways

Hi @alexey-pelykh , I've pushed more codes in all PRs

@alexey-pelykh
Copy link
Contributor

@ntsirintanis thanks! I guess there's no reason having 2 commits for this, just squash them - otherwise looks awesome

@ntsirintanis ntsirintanis force-pushed the 15.0-account_statement_import_online_paypal_update_event_code branch from 9c493e7 to d439e43 Compare December 15, 2023 13:26
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 15.0 milestone Dec 26, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-644-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bc8f877 into OCA:15.0 Dec 26, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ada56b9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants