Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] account_statement_import_base: Migration to 17.0 #647

Merged
merged 22 commits into from
Feb 5, 2024
Merged

[17.0][MIG] account_statement_import_base: Migration to 17.0 #647

merged 22 commits into from
Feb 5, 2024

Conversation

rov-adhoc
Copy link

No description provided.

alexis-via and others added 21 commits December 15, 2023 13:56
@alexis-via @rov-adhoc
Add module account_statement_import_base
bd20798 
The 2 modules account_statement_import_online and
account_statement_import depend on account_statement_import_base (and
not on each other) and share common code, in particular a hook to update
the statement line. So we can now have reconciliation modules that use
this hook and therefore work both on file import and online import. More
details on OCA#481.

Improve bank statement line form view and journal form view.
@alexis-via @rov-adhoc
[ADD] module account_statement_import_file_reconciliation_widget
746b119 
account_statement_import_file_reconciliation_widget is a glue
auto-install module between account_statement_import (will be renamed
account_statement_import_file in v16) and account_reconciliation_widget.
@rov-adhoc
[UPD] Update account_statement_import_base.pot
66cb231
@OCA-git-bot @rov-adhoc
[UPD] README.rst
498e00b
@OCA-git-bot @rov-adhoc
[ADD] icon.png
69bb8ca
@alexis-via @rov-adhoc
[MIG] account_statement_import_base v14 -> v16
fdc5615
@rov-adhoc
[UPD] Update account_statement_import_base.pot
81eb342
@OCA-git-bot @rov-adhoc
[UPD] README.rst
fac822c
@badbole @rov-adhoc
Added translation using Weblate (Croatian)
d77b445
@Gelo-fl @rov-adhoc
Added translation using Weblate (Spanish)
6a59428
@badbole @rov-adhoc
Translated using Weblate (Croatian)
0b9f927 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/hr/
@Gelo-fl @rov-adhoc
Translated using Weblate (Spanish)
0a5abd7 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/es/
@rov-adhoc
Added translation using Weblate (French)
fdacf8e
@rov-adhoc
Translated using Weblate (French)
fa698f5 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/fr/
@adrianojprado @rov-adhoc
Added translation using Weblate (Portuguese (Brazil))
62a1045
@adrianojprado @rov-adhoc
Translated using Weblate (Portuguese (Brazil))
778d4b4 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/pt_BR/
@OCA-git-bot @rov-adhoc
[UPD] README.rst
c739ef3
@weblate @rov-adhoc
Update translation files
fa4af20 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/
@pere-aquarian @rov-adhoc
Added translation using Weblate (Catalan)
1da1fb8
@pere-aquarian @rov-adhoc
Translated using Weblate (Catalan)
ccf98fa 
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_base
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_base/ca/
@rov-adhoc
[IMP] account_statement_import_base: pre-commit execution
54d19a4
@pedrobaeza pedrobaeza changed the title 17.0 mig account statement import base [17.0][MIG] account_statement_import_base: Migration to 17.0 Dec 15, 2023
@pedrobaeza
Copy link
Member

Please remember to name the PR accordingly for being found in searches. I'm going to wait to mark it for migration until you have it green.

@rov-adhoc rov-adhoc force-pushed the 17.0-mig-account_statement_import_base branch 5 times, most recently from ad9836f to 25ee9aa Compare December 15, 2023 18:45
@rov-adhoc
Copy link
Author

Depends on:

@rov-adhoc rov-adhoc force-pushed the 17.0-mig-account_statement_import_base branch from 25ee9aa to 99c1f53 Compare December 15, 2023 19:03
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-account_statement_import_base branch 6 times, most recently from 6860cda to f76122b Compare December 18, 2023 18:56
@rov-adhoc rov-adhoc mentioned this pull request Dec 19, 2023
Closed
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-account_statement_import_base branch from f76122b to b9d1d19 Compare December 28, 2023 18:27
@StefanRijnhart
Copy link
Member

I think you can get your stack of PRs (thanks!) green by adding unmerged dependencies in test-requirements.txt. This is described here: https://odoo-community.org/groups/contributors-15/contributors-175721 (I hope it is still up to date).

@StefanRijnhart
Copy link
Member

In an attempt to restart tests after the dependent module was merged (I don't have access to the 'rerun failed tests button in the Github Actions):

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@StefanRijnhart The rebase process failed, because command git push --force adhoc-dev tmp-pr-647:17.0-mig-account_statement_import_base failed with output:

remote: Permission to adhoc-dev/bank-statement-import.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/adhoc-dev/bank-statement-import/': The requested URL returned error: 403

@StefanRijnhart
Copy link
Member

@rov-adhoc My attempt to restart tests failed. Can you rebase or restart tests manually?

@rov-adhoc rov-adhoc force-pushed the 17.0-mig-account_statement_import_base branch from b9d1d19 to 239841e Compare February 5, 2024 19:47
@rov-adhoc
Copy link
Author

rov-adhoc commented Feb 5, 2024 •
edited
Loading

@StefanRijnhart
done! thanks!! Best regards

StefanRijnhart
StefanRijnhart approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rebase! I checked the code and there is nothing to be migrated in this very simple base module indeed.

pedrobaeza
pedrobaeza approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration account_statement_import_base
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Feb 5, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 5, 2024
Open
12 tasks
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-647-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 370ffee into OCA:17.0 Feb 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c3fc9a7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
10 participants
@rov-adhoc @pedrobaeza @StefanRijnhart @OCA-git-bot @alexis-via @badbole @Gelo-fl @adrianojprado @weblate @pere-aquarian