Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] repo update fix pre-commit #658

Merged
merged 4 commits into from
Feb 3, 2024
Merged

[14.0] repo update fix pre-commit #658

merged 4 commits into from
Feb 3, 2024

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Jan 14, 2024

Fixes pre-commit on:
#645
#633

@bosd
Copy link
Contributor Author

bosd commented Jan 14, 2024

2nd commit fixes:
image
https://github.com/OCA/bank-statement-import/actions/runs/7519164891/job/20467399124?pr=658

@bosd bosd mentioned this pull request Jan 15, 2024
Merged
@StefanRijnhart
Copy link
Member

Can the invalid translations be fixed here (just add the 'new' subsitution variable at the end) or does that need to happen on Weblate?

StefanRijnhart
StefanRijnhart approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see this green! Thanks!

Dranyel-Bosd
Dranyel-Bosd approved these changes Feb 3, 2024
View reviewed changes
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🎆

@StefanRijnhart
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-658-by-StefanRijnhart-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5384815 into OCA:14.0 Feb 3, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d1b25d9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dranyel-Bosd Dranyel-Bosd Dranyel-Bosd approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bosd @StefanRijnhart @OCA-git-bot @Dranyel-Bosd